Per-channel audio buffers #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madebr
reviewed
May 18, 2023
| void S3DisposeOutlet(tS3_outlet* outlet); | ||
| void S3ReleaseOutlet(tS3_outlet* outlet); |
There was a problem hiding this comment.
Asking for rec2, did you invent these names yourself?
There was a problem hiding this comment.
Largely, yes. Although there are some DRS3* wrapper functions that we do know the names of in the dethrace code, so I used those where possible for names and conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls logic from the DOS executable which implemented per-channel audio correctly. Each channel holds a reference to the playing sound instance.
In the windows build, the DirectSound implementation was flawed as the directsound buffer was attached to the sound descriptor, not the sound instance. This meant that only a single instance of a sound could be played at any time.
Also switches s3 function names from “dispose” to “release” to better match the known naming convention.
Fixes #281
Fixes #324