Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding async script test which crashes PhantomJS #103

Merged
merged 1 commit into from
Oct 15, 2012

Conversation

jimevans
Copy link
Contributor

Executing asynchronous scripts was broken by the commit to handle fragment navigation (e66eb0a). Executing sequential asynchronous scripts with navigation in between fails on the third such navigation, crashing PhantomJS. This pull request supplies a test which reproduces the issue.

detro added a commit that referenced this pull request Oct 15, 2012
TEST: Adding async script test which crashes PhantomJS
@detro detro merged commit 4c6fdc4 into detro:master Oct 15, 2012
@detro
Copy link
Owner

detro commented Oct 17, 2012

I can reproduce the issue with and without your commit.
The issue is independent.

And I think it has little to do with ghostdriver and more with a general instability :(

@jimevans
Copy link
Contributor Author

You can repro this issue without the change at e66eb0a ? That's disturbing. I don't get failures in the .NET async script tests unless I have the extra callbacks in place. Note that it's simply attaching the callbacks that causes the issue; the callbacks can be empty functions and you'll still get the error.

@detro
Copy link
Owner

detro commented Oct 18, 2012

You mean the "onUrlChanged" callback, right?

And yes, I can reproduce it every time. With or without.

I have added some more "callback cleanups" and it's happening less, but if
I keep running the tests, I eventually get crashes.
Particularly for long-running Phantomjs processes.

Maybe you are getting it shadowed by the fact that you launch a Process for
every new Driver instance: when I do that it happens less.

On 18 October 2012 14:11, jimevans notifications@github.com wrote:

You can repro this issue without the change at detro/ghostdriver@e66eb0ahttps://github.com/detro/ghostdriver/commit/e66eb0a9aa26ea87f9829dd4f480abfa6e6de494? That's disturbing. I don't get failures in the .NET async script tests
unless I have the extra callbacks in place. Note that it's simply attaching
the callbacks that causes the issue; the callbacks can be empty functions
and you'll still get the error.


Reply to this email directly or view it on GitHubhttps://github.com//pull/103#issuecomment-9563645.

Ivan De Marino
Coder, Technologist, Cook, Italian

blog.ivandemarino.me | www.linkedin.com/in/ivandemarino |
twitter.com/detronizator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants