Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2024-0379: Multiple soundness issues #855

Closed
github-actions bot opened this issue Nov 10, 2024 · 1 comment · Fixed by #877
Closed

RUSTSEC-2024-0379: Multiple soundness issues #855

github-actions bot opened this issue Nov 10, 2024 · 1 comment · Fixed by #877
Assignees
Labels
C-maintenance Category: maintenance

Comments

@github-actions
Copy link

Multiple soundness issues

Details
Status unsound
Package fast-float
Version 0.2.0
URL aldanor/fast-float-rust#35
Date 2024-10-31

fast-float contains multiple soundness issues:

  1. Undefined behavior when checking input length, which has been merged but no package pubished.
  2. Many functions marked as safe with non-local safety guarantees

The library is also unmaintained.

Alternatives

For quickly parsing floating-point numbers third-party crates are generally no longer needed. A fast float parsing algorithm by the author of lexical has been merged into libcore. When requiring direct parsing from bytes and/or partial parsers, the fast-float2 fork of fast-float containing these security patches and reduces overall usage of unsafe.

See advisory page for additional details.

@nwagner84 nwagner84 self-assigned this Nov 11, 2024
@nwagner84 nwagner84 added the C-maintenance Category: maintenance label Nov 11, 2024
@nwagner84
Copy link
Member

polars already switched to fast-float2.

nwagner84 added a commit that referenced this issue Dec 8, 2024
Related-To: #855

Signed-off-by: Nico Wagner <n.wagner@dnb.de>
nwagner84 added a commit that referenced this issue Dec 8, 2024
Signed-off-by: Nico Wagner <n.wagner@dnb.de>
Related-To: #855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-maintenance Category: maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant