Open
Conversation
…nto/memento-api into feat/#61-schedule-alarm
There was a problem hiding this comment.
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/main/java/com/official/memento/schedule/scheduler/scheduleAlarmScheduler.java:18
- Class name 'scheduleAlarmScheduler' should be capitalized (e.g. 'ScheduleAlarmScheduler') to adhere to Java naming conventions.
public class scheduleAlarmScheduler {
Comment on lines
+45
to
+47
| GoogleCredentials credentials = GoogleCredentials.fromStream( | ||
| new FileInputStream(System.getenv("GOOGLE_APPLICATION_CREDENTIALS") | ||
| )); |
There was a problem hiding this comment.
Consider using try-with-resources to safely manage the FileInputStream for GoogleCredentials, which will prevent potential resource leaks.
Suggested change
| GoogleCredentials credentials = GoogleCredentials.fromStream( | |
| new FileInputStream(System.getenv("GOOGLE_APPLICATION_CREDENTIALS") | |
| )); | |
| GoogleCredentials credentials; | |
| try (FileInputStream fis = new FileInputStream(System.getenv("GOOGLE_APPLICATION_CREDENTIALS"))) { | |
| credentials = GoogleCredentials.fromStream(fis); | |
| } |
unanchoi
approved these changes
Apr 14, 2025
Comment on lines
+84
to
+88
| //queryDsl | ||
| implementation("com.querydsl:querydsl-jpa:5.0.0:jakarta") | ||
| annotationProcessor("com.querydsl:querydsl-apt:5.0.0:jakarta") | ||
| annotationProcessor ("jakarta.annotation:jakarta.annotation-api") | ||
| annotationProcessor ("jakarta.persistence:jakarta.persistence-api") |
Contributor
There was a problem hiding this comment.
QueryDSL은 현재 OpenFeign에서 fork해서 계속 프로젝트 업데이트를 진행하고 있습니다~
https://github.com/OpenFeign/querydsl
해당 의존성을 사용하면 좋을 것 같아요.
ksarangee
approved these changes
Apr 16, 2025
Contributor
ksarangee
left a comment
ksarangee
left a comment
There was a problem hiding this comment.
QueryDSL 잘 몰랐는데 신기하네요 참고해서 공부하겠습니다~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
📝 기능 구현 명세
🐥 추가적인 언급 사항
QueryDsl을 도입해봤어요. 원래 도입 이유는 한번에 여러 도메인들을 불러올때 quertDsl을 사용하려고 도입을 했던건데 다 적용하고 보니까 생각했던것 만큼 필요가 없더라구여 근데 라이브러리 버전 때문에 querryDsl을 힘겹게 적용시켰던 터라 버리기 아까워서 나중에 적용할거 그냥 적용해버렷씁니다. ㅎㅎ..
앞으로 단일 도메인 조회는 JPA 여러 도메인을 join해서 한번에 불러올땐 QuerytDsl을 쓰도록 합시다