Own attribute namespace for os-hardening #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upstream cookbook looks good, but the attribute name spacing is less than ideal. This is first attempt to clean this up and make this a useable cookbook. See: #88
| @@ -43,8 +43,6 @@ We deprecated `sysctl` version before `0.6.0`. Future versions of this cookbook | |||
|
|
|||
| ## Attributes | |||
|
|
|||
| * `['desktop']['enable'] = false` | |||
There was a problem hiding this comment.
any reason why this was removed?
|
superseeds #88 |
|
Great work @joshmyers LGTM, once we fixed the highlighted issues |
|
Highlighted issues are fixed in following PRs. |
|
This will be released as part of the 2.0 version of this cookbook |
chris-rock
added a commit
that referenced
this pull request
May 29, 2016
Fix issues highlighted in #114
rollbrettler
pushed a commit
to rollbrettler/chef-os-hardening
that referenced
this pull request
Sep 16, 2016
Use new InSpec integration tests
This was referenced Dec 14, 2016
artem-sidorenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upstream cookbook looks good, but the attribute name spacing is
less than ideal. This is first attempt to clean this up and make this a
useable cookbook.
See: #88