Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for fedora: lets use generic package resource #176

Merged
merged 1 commit into from
Oct 29, 2017
Merged

Conversation

artem-sidorenko
Copy link
Member

On Fedora dnf is used and not yum. Lets chef decide which provider to
use

Signed-off-by: Artem Sidorenko artem@posteo.de

On Fedora dnf is used and not yum. Lets chef decide which provider to
use

Signed-off-by: Artem Sidorenko <artem@posteo.de>
@artem-sidorenko
Copy link
Member Author

@atomic111 @chris-rock can you please have a look at fedora logs? Any idea how we can fix the missing 'rsyslog' and 'auditd'? I'm not sure if we should install them

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ff3dac1 on fedora-fix into dd456fe on master.

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a great improvement. Thank you @artem-sidorenko

@chris-rock chris-rock merged commit ab5a27d into master Oct 29, 2017
@chris-rock chris-rock deleted the fedora-fix branch October 29, 2017 16:29
@artem-sidorenko
Copy link
Member Author

@chris-rock thanks! But what do you think about rsyslog and audit (s. above)?

@chris-rock
Copy link
Member

I think we should track that in its own issue. Auditd is something we should install, since this is consistent with the other os. We may want to introduce a flag to deactivate auditd. Rsyslog only if we need it.

@artem-sidorenko artem-sidorenko changed the title Fix: lets use generic package resource Fix for fedora: lets use generic package resource Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants