Control ownership of /var/log #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recipes/minimize_access.rb
Outdated
| directory '/var/log' do | ||
| owner 'root' | ||
| if node['platform'] == 'ubuntu' | ||
| group Chef::VersionConstraint.new('>= 14.04').include?(node['platform_version']) ? 'syslog' : 'root' |
There was a problem hiding this comment.
@shoekstra do we need the version constraint? Is the check for ubuntuis not enough here?
There was a problem hiding this comment.
@artem-sidorenko just checked and 12.04 LTS is EOL, so it can be removed.
shoekstra
force-pushed
the
fix_ubuntu_tests
branch
from
e8f05d2 to
0711510
Compare
|
@artem-sidorenko commit updated 👍 |
recipes/minimize_access.rb
Outdated
|
|
||
| # /var/log should restricted to root or syslog on ubuntu > 14.04 | ||
| directory '/var/log' do | ||
| owner 'root'a |
There was a problem hiding this comment.
@shoekstra could you please fix this? (a) ;-)
There was a problem hiding this comment.
Whoops, fix incoming. Good spot :)
Signed-off-by: Stephen Hoekstra <shoekstra@schubergphilis.com>
shoekstra
force-pushed
the
fix_ubuntu_tests
branch
from
0711510 to
c545dd2
Compare
artem-sidorenko
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu tests should be fixed once dev-sec/linux-baseline#83 is merged.
CC @artem-sidorenko