Add pam_systemd.so to system-auth-ac #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
reviewed
Apr 23, 2018
There was a problem hiding this comment.
Thank you @avanier Great addition, I left a comment for a small attribute name improvement
| @@ -35,5 +35,8 @@ password required pam_deny.so | |||
|
|
|||
| session optional pam_keyinit.so revoke | |||
| session required pam_limits.so | |||
| <% if node['os-hardening']['desktop']['enable'] && node['platform'] == 'fedora' %> | |||
There was a problem hiding this comment.
I would like to reuse the same naming pattern as above:
node['os-hardening']['auth']['pam']['pam_systemd']['enable']
|
@chris-rock This should work, but for some reason I'm unable to converge the kitchens now. |
|
Alright, got my kitchen to converge. No explosions. |
|
@chris-rock Bump, if I may. |
artem-sidorenko
requested changes
Jun 30, 2018
attributes/default.rb
Outdated
| @@ -79,6 +79,7 @@ | |||
| default['os-hardening']['auth']['pam']['tally2']['template_cookbook'] = 'os-hardening' | |||
| default['os-hardening']['auth']['pam']['passwdqc']['template_cookbook'] = 'os-hardening' | |||
| default['os-hardening']['auth']['pam']['system-auth']['template_cookbook'] = 'os-hardening' | |||
| default['os-hardening']['auth']['pam']['pam_systemd']['enable'] = node['os-hardening']['desktop']['enable'] && node['platform'] == 'fedora' | |||
| @@ -35,5 +35,8 @@ password required pam_deny.so | |||
|
|
|||
| session optional pam_keyinit.so revoke | |||
| session required pam_limits.so | |||
| <% if node['os-hardening']['auth']['pam']['pam_systemd']['enable'] %> | |||
| -session optional pam_systemd.so | |||
There was a problem hiding this comment.
I think we can remove the leading -
|
@artem-sidorenko Rebased on upstream master, and requested changes are applied. 🤘 |
artem-sidorenko
approved these changes
Jul 2, 2018
|
@avanier thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206.
Allows Gnome Display Manager to start properly under Fedora 27.