Expose list of packages to remove as an attribute #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rockstar04 seemed to agree having this attribute controlled was a sensible next step. Hopefully @chris-rock was vaguely expecting this from my comments on #93 :-) |
|
@mikemoate this is great. I like that this is configurable. Please rebase to the latest master and I will merge it! |
This gives users some flexibility to remove additional packages or keep some of these packages if they have valid reasons, whilst preserving the good default behaviour.
Document the attribute controlling the list of packages to remove, including the default value (which preserves the existing behaviour).
mikemoate
force-pushed
the
packages_as_attribute
branch
from
1d3185f to
7fdf932
Compare
|
@chris-rock rebased and CI is in progress. I'm still looking at testing for this functionality, hopefully I'll find some time at the weekend. Any thoughts on when a new version of this cookbook might be released to the supermarket? |
|
Great work @mikemoate I am going to release a new version by end of the week. |
chris-rock
added a commit
that referenced
this pull request
Nov 25, 2015
Expose list of packages to remove as an attribute
rollbrettler
pushed a commit
to rollbrettler/chef-os-hardening
that referenced
this pull request
Sep 16, 2016
x11 forwarding should be configurable like tcp and agent forwarding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows on from my recent pull request for #90
This exposes the list of packages to be removed by the cookbook as an attribute, with the default value of that attribute preserving the existing behaviour (i.e. creates a customisation point without a breaking change).
My primary reason for exposing this was to allow users of the cookbook to override this list should it be needed (in our specific case, we have an nagios monitoring agent that requires xinetd, which we have then taken further steps to harden) without needing to fork the cookbook.
A secondary reason is that it may make unit testing this functionality (which I am looking at for a subsequent pull request) easier.
I wasn't sure on style for README changes, so welcome any feedback.