-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookstyle Bot Auto Corrections with Cookstyle 7.31.1 #239
Open
cookstyle
wants to merge
1
commit into
master
Choose a base branch
from
cookstyle_bot/cookstyle_7_31_1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.31.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client. ### Style/Encoding - **/Berksfile:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/Gemfile:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/Rakefile:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/attributes/default.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/libraries/devsec_ssh.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/metadata.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/recipes/client.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/recipes/default.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/recipes/server.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/recipes/unlock.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/spec/libraries/devsec_ssh_spec.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/spec/recipes/client_spec.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/spec/recipes/default_spec.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/spec/recipes/server_spec.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/spec/recipes/unlock_spec.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/spec/shared_examples_crypto.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/spec/spec_helper.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) - **/test/fixtures/cookbooks/test/recipes/default.rb:1**: Unnecessary utf-8 encoding comment. (https://rubystyle.guide#utf-8) ### Chef/Style/CommentFormat - **/attributes/default.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/attributes/default.rb:7**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/devsec_ssh.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/devsec_ssh.rb:7**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/devsec_ssh.rb:8**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/devsec_ssh.rb:9**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/libraries/devsec_ssh.rb:10**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/metadata.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/client.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/client.rb:7**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/client.rb:8**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/default.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/default.rb:7**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/default.rb:8**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/server.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/server.rb:7**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/server.rb:8**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/unlock.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/recipes/unlock.rb:7**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/libraries/devsec_ssh_spec.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/recipes/client_spec.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/recipes/client_spec.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/recipes/default_spec.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/recipes/server_spec.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/recipes/server_spec.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/recipes/unlock_spec.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/shared_examples_crypto.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/shared_examples_crypto.rb:5**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/spec/spec_helper.rb:4**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/test/fixtures/cookbooks/test/recipes/default.rb:3**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) - **/test/fixtures/cookbooks/test/recipes/default.rb:6**: Properly format header comments (https://docs.chef.io/workstation/cookstyle/chef_style_commentformat) ### Layout/CaseIndentation - **/attributes/default.rb:22**: Indent `when` as deep as `case`. (https://rubystyle.guide#indent-when-to-case) - **/attributes/default.rb:24**: Indent `when` as deep as `case`. (https://rubystyle.guide#indent-when-to-case) - **/attributes/default.rb:26**: Indent `when` as deep as `case`. (https://rubystyle.guide#indent-when-to-case) ### Style/ConditionalAssignment - **/attributes/default.rb:23**: Use the return of the conditional for variable assignment and comparison. - **/attributes/default.rb:43**: Use the return of the conditional for variable assignment and comparison. - **/attributes/default.rb:51**: Use the return of the conditional for variable assignment and comparison. ### Layout/IndentationWidth - **/attributes/default.rb:23**: Use 2 (not -49) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/attributes/default.rb:25**: Use 2 (not -49) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/attributes/default.rb:27**: Use 2 (not -49) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/attributes/default.rb:29**: Use 2 (not -49) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/attributes/default.rb:42**: Use 2 (not -49) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/attributes/default.rb:44**: Use 2 (not -49) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/attributes/default.rb:49**: Use 2 (not -54) spaces for indentation. (https://rubystyle.guide#spaces-indentation) - **/attributes/default.rb:51**: Use 2 (not -54) spaces for indentation. (https://rubystyle.guide#spaces-indentation) ### Layout/ElseAlignment - **/attributes/default.rb:28**: Align `else` with `when`. - **/attributes/default.rb:43**: Align `else` with `if`. - **/attributes/default.rb:50**: Align `else` with `if`. ### Chef/Style/UsePlatformHelpers - **/attributes/default.rb:35**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/attributes/default.rb:36**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/libraries/devsec_ssh.rb:197**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/recipes/server.rb:52**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/recipes/server.rb:54**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) - **/test/fixtures/cookbooks/test/recipes/default.rb:21**: Use platform? and platform_family? helpers to check a node's platform (https://docs.chef.io/workstation/cookstyle/chef_style_useplatformhelpers) ### Chef/Style/UnnecessaryPlatformCaseStatement - **/attributes/default.rb:43**: Use the platform?() and platform_family?() helpers instead of a case statement that only includes a single when statement. (https://docs.chef.io/workstation/cookstyle/chef_style_unnecessaryplatformcasestatement) - **/attributes/default.rb:51**: Use the platform?() and platform_family?() helpers instead of a case statement that only includes a single when statement. (https://docs.chef.io/workstation/cookstyle/chef_style_unnecessaryplatformcasestatement) - **/recipes/server.rb:137**: Use the platform?() and platform_family?() helpers instead of a case statement that only includes a single when statement. (https://docs.chef.io/workstation/cookstyle/chef_style_unnecessaryplatformcasestatement) ### Layout/ExtraSpacing - **/attributes/default.rb:71**: Unnecessary spacing detected. - **/attributes/default.rb:72**: Unnecessary spacing detected. - **/attributes/default.rb:73**: Unnecessary spacing detected. ### Layout/SpaceAroundOperators - **/attributes/default.rb:71**: Operator `=` should be surrounded by a single space. (https://rubystyle.guide#spaces-operators) - **/attributes/default.rb:72**: Operator `=` should be surrounded by a single space. (https://rubystyle.guide#spaces-operators) ### Migration/DepartmentName - **/attributes/default.rb:83**: Department name is missing. ### Style/PercentLiteralDelimiters - **/libraries/devsec_ssh.rb:45**: `%i`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:50**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:51**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:52**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:55**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:56**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:57**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:59**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:62**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:63**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:65**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:76**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:77**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/libraries/devsec_ssh.rb:78**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/recipes/server.rb:54**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/recipes/server.rb:147**: `%i`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/recipes/server.rb:148**: `%i`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/recipes/server.rb:149**: `%i`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/recipes/server.rb:150**: `%i`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/recipes/server.rb:152**: `%i`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/recipes/server.rb:154**: `%i`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/recipes/server.rb:155**: `%i`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/recipes/server.rb:157**: `%i`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/recipes/server.rb:159**: `%i`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/spec/libraries/devsec_ssh_spec.rb:257**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/spec/recipes/client_spec.rb:185**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/spec/recipes/server_spec.rb:610**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/spec/recipes/server_spec.rb:623**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/spec/recipes/server_spec.rb:757**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) - **/spec/shared_examples_crypto.rb:48**: `%w`-literals should be delimited by `(` and `)`. (https://rubystyle.guide#percent-literal-braces) ### Style/TrailingCommaInHashLiteral - **/libraries/devsec_ssh.rb:52**: Put a comma after the last item of a multiline hash. - **/libraries/devsec_ssh.rb:59**: Put a comma after the last item of a multiline hash. - **/libraries/devsec_ssh.rb:65**: Put a comma after the last item of a multiline hash. - **/libraries/devsec_ssh.rb:66**: Put a comma after the last item of a multiline hash. - **/libraries/devsec_ssh.rb:71**: Put a comma after the last item of a multiline hash. - **/libraries/devsec_ssh.rb:78**: Put a comma after the last item of a multiline hash. - **/recipes/client.rb:52**: Put a comma after the last item of a multiline hash. - **/recipes/server.rb:155**: Put a comma after the last item of a multiline hash. - **/recipes/server.rb:184**: Put a comma after the last item of a multiline hash. - **/spec/libraries/devsec_ssh_spec.rb:45**: Put a comma after the last item of a multiline hash. - **/spec/libraries/devsec_ssh_spec.rb:48**: Put a comma after the last item of a multiline hash. - **/spec/libraries/devsec_ssh_spec.rb:49**: Put a comma after the last item of a multiline hash. - **/spec/libraries/devsec_ssh_spec.rb:50**: Put a comma after the last item of a multiline hash. ### Style/ReturnNil - **/libraries/devsec_ssh.rb:166**: Use `return` instead of `return nil`. ### Chef/RedundantCode/LongDescriptionMetadata - **/metadata.rb:24**: The long_description metadata.rb method is not used and is unnecessary in cookbooks. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_longdescriptionmetadata) - **/test/fixtures/cookbooks/test/metadata.rb:6**: The long_description metadata.rb method is not used and is unnecessary in cookbooks. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_longdescriptionmetadata) ### Chef/Modernize/RespondToInMetadata - **/metadata.rb:27**: It is no longer necessary to use respond_to? or defined? in metadata.rb in Chef Infra Client 12.15 and later (https://docs.chef.io/workstation/cookstyle/chef_modernize_respondtoinmetadata) ### Chef/RedundantCode/RecipeMetadata - **/metadata.rb:40**: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_recipemetadata) - **/metadata.rb:41**: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_recipemetadata) - **/metadata.rb:42**: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead. (https://docs.chef.io/workstation/cookstyle/chef_redundantcode_recipemetadata) ### Layout/TrailingWhitespace - **/recipes/server.rb:105**: Trailing whitespace detected. (https://rubystyle.guide#no-trailing-whitespace) ### Chef/Modernize/FoodcriticComments - **/recipes/server.rb:107**: Remove legacy code comments that disable Foodcritic rules (https://docs.chef.io/workstation/cookstyle/chef_modernize_foodcriticcomments) ### Layout/DotPosition - **/spec/recipes/client_spec.rb:59**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/client_spec.rb:64**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/client_spec.rb:138**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/client_spec.rb:151**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/client_spec.rb:164**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/client_spec.rb:177**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/client_spec.rb:190**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/client_spec.rb:203**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:69**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:146**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:159**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:172**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:196**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:212**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:224**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:442**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:454**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:471**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:485**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:512**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:534**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:546**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:552**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:564**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:570**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:582**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:588**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:593**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:598**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:603**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:615**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:628**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:635**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:648**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:661**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:668**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:681**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:695**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:709**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:722**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:735**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:736**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:749**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:762**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:774**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:787**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/recipes/server_spec.rb:801**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/shared_examples_crypto.rb:23**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/shared_examples_crypto.rb:32**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/shared_examples_crypto.rb:41**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/shared_examples_crypto.rb:51**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/shared_examples_crypto.rb:60**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/shared_examples_crypto.rb:69**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) - **/spec/shared_examples_crypto.rb:78**: Place the . on the next line, together with the method name. (https://rubystyle.guide#consistent-multi-line-chains) ### Style/RegexpLiteral - **/spec/recipes/server_spec.rb:225**: Use `%r` around regular expression. (https://rubystyle.guide#percent-r) ### Chef/Deprecations/DeprecatedChefSpecPlatform - **/spec/recipes/server_spec.rb:276**: Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/main/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3 (https://docs.chef.io/workstation/cookstyle/chef_deprecations_deprecatedchefspecplatform) - **/spec/recipes/server_spec.rb:465**: Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/main/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3 (https://docs.chef.io/workstation/cookstyle/chef_deprecations_deprecatedchefspecplatform) ### Layout/EmptyLines - **/spec/spec_helper.rb:25**: Extra blank line detected. (https://rubystyle.guide#two-or-more-empty-lines) ### Chef/Deprecations/ChefSpecCoverageReport - **/spec/spec_helper.rb:26**: Don't use the deprecated ChefSpec coverage report functionality in your specs. (https://docs.chef.io/workstation/cookstyle/chef_deprecations_chefspeccoveragereport) ### Chef/Sharing/InvalidLicenseString - **/test/fixtures/cookbooks/test/metadata.rb:4**: Cookbook metadata.rb does not use a SPDX compliant license string or "all rights reserved". See https://spdx.org/licenses/ for a complete list of license identifiers. (https://docs.chef.io/workstation/cookstyle/chef_sharing_invalidlicensestring) Signed-off-by: Cookstyle <cookbooks@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is automatically generated by the Cookstyle Bot using the latest version of Cookstyle (7.31.1). Adopting changes suggested by Cookstyle improves cookbook readability, avoids common coding mistakes, and eases upgrades to newer versions of the Chef Infra Client.
Style/Encoding
Chef/Style/CommentFormat
Layout/CaseIndentation
when
as deep ascase
. (https://rubystyle.guide#indent-when-to-case)when
as deep ascase
. (https://rubystyle.guide#indent-when-to-case)when
as deep ascase
. (https://rubystyle.guide#indent-when-to-case)Style/ConditionalAssignment
Layout/IndentationWidth
Layout/ElseAlignment
else
withwhen
.else
withif
.else
withif
.Chef/Style/UsePlatformHelpers
Chef/Style/UnnecessaryPlatformCaseStatement
Layout/ExtraSpacing
Layout/SpaceAroundOperators
=
should be surrounded by a single space. (https://rubystyle.guide#spaces-operators)=
should be surrounded by a single space. (https://rubystyle.guide#spaces-operators)Migration/DepartmentName
Style/PercentLiteralDelimiters
%i
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%i
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%i
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%i
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%i
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%i
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%i
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%i
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%i
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%i
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)%w
-literals should be delimited by(
and)
. (https://rubystyle.guide#percent-literal-braces)Style/TrailingCommaInHashLiteral
Style/ReturnNil
return
instead ofreturn nil
.Chef/RedundantCode/LongDescriptionMetadata
Chef/Modernize/RespondToInMetadata
Chef/RedundantCode/RecipeMetadata
Layout/TrailingWhitespace
Chef/Modernize/FoodcriticComments
Layout/DotPosition
Style/RegexpLiteral
%r
around regular expression. (https://rubystyle.guide#percent-r)Chef/Deprecations/DeprecatedChefSpecPlatform
Layout/EmptyLines
Chef/Deprecations/ChefSpecCoverageReport
Chef/Sharing/InvalidLicenseString
Signed-off-by: Cookstyle cookbooks@chef.io