-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(6.1): regression expected_gid #100
fix(6.1): regression expected_gid #100
Conversation
@@ -191,8 +191,6 @@ | |||
gshadow_files = ['/etc/gshadow'] | |||
gshadow_files << '/usr/share/baselayout/gshadow' if file('/etc/nsswitch.conf').content =~ /^gshadow:\s+(\S+\s+)*usrfiles/ | |||
|
|||
expected_gid = 0 | |||
expected_gid = 42 if os.debian? | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove one of the 2 blank lines here ? The checks will pass normally after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that!
I was trying to make sure the Travis build passed before logging off that day but the build was queued for 30min + and forgot to follow up.
Would a PR to switch from Travis to GH workflow be something that could happen down the road?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We started migrating some of the automation to Github actions (mainly the release process). But there is currently no schedule for the CI.
* refactor `attribute()` -> `input()` * fix regression/add supportfor evaluating gid on /etc/shadow and friends on - debian - suse - alpine Ref: - dev-sec#33 - dev-sec/linux-baseline#70 on-behalf-of: @Logicworks <dmiguel@logicworks.net> Signed-off-by: Deric Miguel <dmiguel@logicworks.net>
7288a4d
to
0e0141f
Compare
@deric4 If you are interested in joining us, you can contact me or @chris-rock (he is the lead). |
Oh cool! Is the contact info in your guys' GitHub profiles the best way of following up? |
You mean my email ? Yes, it is :) |
refactor
attribute()
->input()
fix regression/add supportfor evaluating gid on /etc/shadow and friends on
Ref:
- Debian uses group 42 shadow #33
- os-02: Fix for SUSE environments linux-baseline#70
fix max permissions on /etc/shadow:
0644
->0640
on-behalf-of: @Logicworks dmiguel@logicworks.net
Signed-off-by: Deric Miguel dmiguel@logicworks.net