Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(6.1): regression expected_gid #100

Merged

Conversation

deric4
Copy link
Member

@deric4 deric4 commented Jan 5, 2021

on-behalf-of: @Logicworks dmiguel@logicworks.net
Signed-off-by: Deric Miguel dmiguel@logicworks.net

@@ -191,8 +191,6 @@
gshadow_files = ['/etc/gshadow']
gshadow_files << '/usr/share/baselayout/gshadow' if file('/etc/nsswitch.conf').content =~ /^gshadow:\s+(\S+\s+)*usrfiles/

expected_gid = 0
expected_gid = 42 if os.debian?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove one of the 2 blank lines here ? The checks will pass normally after that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that!

I was trying to make sure the Travis build passed before logging off that day but the build was queued for 30min + and forgot to follow up.

Would a PR to switch from Travis to GH workflow be something that could happen down the road?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We started migrating some of the automation to Github actions (mainly the release process). But there is currently no schedule for the CI.

* refactor `attribute()` -> `input()`
* fix regression/add supportfor evaluating gid on /etc/shadow and friends on
	- debian
	- suse
	- alpine
  Ref:
  	- dev-sec#33
	- dev-sec/linux-baseline#70

on-behalf-of: @Logicworks <dmiguel@logicworks.net>
Signed-off-by: Deric Miguel <dmiguel@logicworks.net>
@deric4 deric4 force-pushed the fix/regression-debian-file-perms branch from 7288a4d to 0e0141f Compare January 7, 2021 18:56
@micheelengronne micheelengronne merged commit 5216ec6 into dev-sec:master Jan 8, 2021
@micheelengronne
Copy link
Member

@deric4 If you are interested in joining us, you can contact me or @chris-rock (he is the lead).

@deric4
Copy link
Member Author

deric4 commented Jan 8, 2021

@deric4 If you are interested in joining us, you can contact me or @chris-rock (he is the lead).

Oh cool! Is the contact info in your guys' GitHub profiles the best way of following up?

@micheelengronne
Copy link
Member

You mean my email ? Yes, it is :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants