Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update inspec.yml #64

Closed
wants to merge 5 commits into from
Closed

update inspec.yml #64

wants to merge 5 commits into from

Conversation

MoisesTapia
Copy link
Contributor

the value default is deprecated and in the new versions of inspec we need change the value default for value

the value default is deprecated and in the new versions of inspec we need change the value default for value
@MoisesTapia
Copy link
Contributor Author

the value default is deprecated and in the new versions of inspec we need change the value default for value

@MoisesTapia MoisesTapia closed this May 8, 2020
@MoisesTapia MoisesTapia reopened this May 8, 2020
@chris-rock
Copy link
Member

@MoisesTapia Great improvement. Can you sign off the commits please?

@MoisesTapia
Copy link
Contributor Author

MoisesTapia commented May 8, 2020

@chris-rock I try to sing off but git return me an error:
remote: Permission to dev-sec/cis-docker-benchmark.git denied to MoisesTapia.
fatal: unable to access 'https://github.com/dev-sec/cis-docker-benchmark/': The requested URL returned error: 403

@micheelengronne
Copy link
Member

Sign on your own repository. On https://github.com/MoisesTapia/cis-docker-benchmark

the value default is deprecated and in the new versions of inspec we need change the value default for value

Signed-off-by: MoisesTapia <moisestapia741@gmail.com>
…nchmark

Update inspec.yml

Signed-off-by: MoisesTapia <moisestapia741@gmail.com>
@MoisesTapia MoisesTapia closed this May 8, 2020
@MoisesTapia MoisesTapia reopened this May 8, 2020
@MoisesTapia
Copy link
Contributor Author

I am trying to sign it from my repository but I cannot what are the command to sign it?

@micheelengronne
Copy link
Member

Click on Details on the DCO line in the Some checks were not successful.

…nchmark

Update
Inspec.yml

Signed-off-by: MoisesTapia <moisestapia741@gmail.com>
@MoisesTapia
Copy link
Contributor Author

Done

@micheelengronne
Copy link
Member

micheelengronne commented May 8, 2020

It is still not green. Is your local git email the same as the one you set on Github ? It should be.

Edit: In fact, you successfully signed the last commit. You must sign all of them.

@MoisesTapia
Copy link
Contributor Author

yes it's the same ...

This commit was signed with a verified signature.

commit

@micheelengronne
Copy link
Member

Yes, I saw it. It is your previous commits you must also sign.

@MoisesTapia
Copy link
Contributor Author

sorry but, how can I do it

@micheelengronne
Copy link
Member

I think you should squash your commits into one and sign off this resulting commit.

Here is a tutorial on how to accomplish that https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

@micheelengronne
Copy link
Member

I you are unsure of what you do, do a backup of your git repo as incorrectly rewriting a git history can lead to commit loss (data loss).

@MoisesTapia MoisesTapia closed this May 8, 2020
@micheelengronne micheelengronne mentioned this pull request May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants