Introducing find_ssh_version and guess_ssh_version #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ified. In that case return a fallback with guess_ssh_version. This behavior is identical to devsec_ssh.rb in the chef ssh baseline. Also adding a find_ssh_version method that behaves almost exactly like the one in devsec_ssh.rb. Signed-off-by: jheinz <heinzjonathan95@gmail.com>
JHeinzde
force-pushed
the
refactoring/ssh_crypto
branch
from
5b8e2bf
to
ee10de4
Compare
|
@JHeinzde I am sorry I missed this PR. This looks like an awesome improvement. I am going to test it within the next week. Can you make sure that Travis will be happy? |
|
@chris-rock don't wait for Jonathan, he won't be able to answer anything in the next weeks or maybe even several months (due to accident) :-( Feel free to proceed with review - I'll try to help/takeover if/when I've time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an implementation for find_ssh_version and guess_ssh_version. These provide the same behaviors as the methods in devsec_ssh.rb in the chef ssh hardening cookbook. This PR is the first in a series of PRs that will try to add the behavior of the chef ssh hardening implementation. Related to #126