Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kex): introduce kex for 8.0+, used for alpine and fedora 30+ #155

Closed
wants to merge 2 commits into from
Closed

feat(kex): introduce kex for 8.0+, used for alpine and fedora 30+ #155

wants to merge 2 commits into from

Conversation

kostasns
Copy link

This PR is a second part of dev-sec/ansible-ssh-hardening#281
It also addresses #144 somewhat

From Fedora 30 ( the one which is currently used in rndmh3ro/docker-fedora-ansible:latest image for testing ) OpenSSH 8.0p1 is installed. And with changes in dev-sec/ansible-ssh-hardening#254 a separate list of kex was introduced for 8.0 and above in ansible role.

So this PR modifies the test to check for correct list of kex for Fedora with version 30 and higher. I've also took the liberty to set the kex80 for alpine, although currently not used in testing docker-alpine-ansible image will fall into same OpenSSH 8.0+ category.

This potentially will break other tests
It seems chef-ssh-hardening repo does set kex66 list for both Fedora 29 and 30
don't know if there are other places to watch out for
What is the best way forward for this one ?

Signed-off-by: Kostas <kostas@nsbox.lt>
@kostasns
Copy link
Author

Not being to familiar with Ruby, can someone advise on how to fix the remaining errors ? Thanks :)

@chris-rock
Copy link
Member

Thank you @kostasns for raising awareness with this pull request. Your PR pushed the community. We went with #172 instead of this one since it covered more operating systems and turned green on CI. I am going to close this PR.

@chris-rock chris-rock closed this May 25, 2020
@kostasns kostasns deleted the fedora_kex80 branch May 25, 2020 07:45
@kostasns
Copy link
Author

No problem at all. Glad to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants