[pull] main from 47-studio-org:main #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…eslint#15967) * chore: avoid generating subdirectories for each page on new docs site Refs eslint#15844 * add comments * refactor pathPrefix * update component library permalinks * rewrite URLs * fix indentation in package.json
Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much. - Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs [Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/) Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
* docs: Switch to version-relative URLs Implements /docs/head and /docs/latest as ways to load the docs from the HEAD branch and from the latest release. * Update Makefile.js * Update docs/src/_includes/components/nav-version-switcher.html Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Update docs/src/_includes/components/version-switcher.html Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Update docs/src/_includes/partials/versions-list.html Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
* docs: Add rules meta info to rule pages * Address feedback * Update release to include rules metadata * Fix message * Update git tag * Fix conflicts * Update docs/src/_includes/components/rule-categories.macro.html Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Create annotated tag Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
* docs: Update analytics, canonical URL, ads * Update docs/src/_includes/layouts/base.html Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Update docs/src/_data/links.json Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Update docs/src/_includes/partials/docs-footer.html Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
…15986) * fix: build commands * build: remove images in dev server
* chore: fix sitemap * refactor conditions for generating sitemaps
* docs: remove table of contents from markdown text * docs: remove TOC from nodejs-api
This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure. Dependabot helps in keeping the supply chain secure https://docs.github.com/en/code-security/dependabot GitHub actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool Signed-off-by: naveen <172697+naveensrinivasan@users.noreply.github.com>
* docs: Update versions dropdown * Remove versions links
* feat: add rule logical-assignment-operators Fixes eslint#13689 * docs: update rule documentation - State the concept of the rule clearer - Increase the heading level for options * chore: unify ast-utils import * fix: only check for void 0 in undefined checks * fix: always fix for the logical pattern * feat: support yoda conditions in if conditions * fix: remove parenthesis around assignment target if necessary * fix: parenthesize logical pattern if needed * fix: add semicolon for if patterns with a body if needed * fix: remove file extension from import Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * fix: check strictness of global scope instead of current scope to avoid checking for with * fix: check for mixed ?? and ||/&& operators in the fix for never * fix: check previous token for continuation problems in the if fix * feat: support else if (and fix suggest cases for if) * fix: do not remove else keyword for else if * fix: if cases also suggest based on potential getter * fix: also fix if only a single property is accessed for the if pattern * fix: do not fix logical patterns with a deeper access * fix: check whether Boolean references a global * fix: allow test conditions to access the same static property (a.b <=> a['b']) * fix: use the whole assignment operator with equals in the message and add operator for 'if' messages * docs: remove edit_link * docs: remove description from docs as it is autogenerated from rule.meta.docs.description * docs: move introductory text before rule details * docs: add missing 'logical' to rule description * docs: fix formatting for options * docs: include all logical operators for option 'never' * docs: add examples for option 'always' * docs: add examples of for the 'enforceForIfStatements' option and swap correct with incorrect sections * fix: disallow optional chaining for the logical pattern * fix: fixer does not delete parenthesis around the right operand in the assignment pattern * fix: remove multiple parenthesis around the right operand in the logical pattern * test: add data property for suggestions * docs: add missing comma in description Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * test: clean up unnecessary data, add missing data and pass missing options for test case * fix: do not allow property accesses in a computed property when checking for a single property access * test: add test cases for private identifiers Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
…ect (eslint#16317) * docs: Add note to disclose inappropriate behavior Due to eslint#16305 (comment) the falsely suggestion should be disclose to users to avoid further confusion See eslint#16305 * docs(prefer-reflect): Remove the section about `getOwnPropertyNames` Make the document clean * docs: Apply suggestions from code review Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * docs: Mark the value as string Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * docs: remove duplicated consecutive blank line Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Update docs/src/rules/prefer-reflect.md Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Latest version of the package includes more aggressive caching. Refs eslint#16302
Add more detailed setup information to the docs README.
* fix: counts graphemes instead of code units * test: add more tests * test: add more valid tests * docs: mention about grapehemes * fix: first check if string is ASCII * fix: use regex * Update docs/src/rules/id-length.md Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * fix: add `max: 1` to valid tests * fix: add tests for Variation Selectors * Update tests/lib/rules/id-length.js Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> * Update tests/lib/rules/id-length.js Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com> Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
* docs: typos in comments/JSDocs * fix: bad CSS position value rekative * fix: UK spelling of behavior for ScrollOption
Bumps [actions/stale](https://github.com/actions/stale) from 5 to 6. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v5...v6) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* do not use `gitignoreToMinimatch` on `--ignore-pattern` * remove .eslintignore lookup * remove flat-eslint tests that assume .eslintignore lookup * remove --ignore-path CLI option * remove ignorePath contructor option * update docs and jsdoc * do not use gitIgnoreToMinimatch on ignorePatterns constructor option
* docs: Conflicting fixes Provide additional documentation on conflicting fixes. Fixes eslint#13721 * Update docs/src/developer-guide/working-with-rules.md Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com> Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
* chore: Rename CODEOWNERS * chore: delete CODEWONERS
* feat: Pass --max-warnings value to formatters Fixes eslint#14881 * Make formatter docs wording consistent Originally suggested by @fasttime in eslint#16348 (comment). * Update LoadedFormatter and FormatterFunction typedefs Originally suggested by @fasttime in eslint#16348 (comment). Internally, I define two types, `MaxWarningsExceeded` and `ResultsMeta`, that the updated `LoadedFormatter` and `FormatterFunction` types can use. I'm then able to reuse the `ResultsMeta` type instead of the generic `Object` type in `ESLint` and `FlatESLint`'s `format` wrapper functions. Externally in the Node.js API docs, I describe the new second argument to `LoadedFormatter`'s `format` method inline rather than separately documenting the new types. While working on this, I noticed that `FlatESLint` is using the pre-PR eslint#15727 `Formatter` type rather than `LoadedFormatter` and `FormatterFunction`. I'll fix that in a follow-up PR to keep this PR scoped to passing `maxWarningsExceeded` info.
Follow up nodejs/node#37302. This PR suppress the following Node.js warning. ```console % node -v v18.10.0 % cd path/to/eslint % node Makefile mocha Running unit tests (snip) (node:63796) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead (Use `node --trace-deprecation ...` to show where the warning was created) ``` And added compatibility condition to prevent the following error when using Node.js 14.13.1 or lower. ```console % node -v v14.13.1 % npx mocha tests/lib/eslint/flat-eslint.js (snip) 1) FlatESLint lintFiles() multiple processors "after each" hook for "should lint only JavaScript blocks.": TypeError: fsp.rm is not a function ```
* feat: Swap out Globby for custom globbing solution. Removes globby due to numerous issues with ignoring files and returning the correct files. Fixes eslint#16354 Fixes eslint#16340 Fixes eslint#16300 * Fix failing test * Add test for 16300 * Make more tests pass * Fix another test * Add another test * Remove old test * Fix cli tests * Bump up Mocha timeout for Node 18 * Revert timeout bump * Manually use stream * clean up comment * Set concurrency back to default * Fix remaining tests * Cleanup requires
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )