[pull] main from MarcelRaschke:main #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…ourcegraph#32264) The main change is to pass around repo ids, which are int32, instead of repo names which are strings. Also skipped some intermediary copying of data out of repos by just passing repo structs around.
…2244) Adds a search request when loading feature flags that attempts to search `sourcegraph/sourcegraph` on the Sourcegraph instance for (potential) mentions of each feature flag on the version of the repo that corresponds to the product build, and renders them in a collapsible view. If no results are found, such as if the Sourcegraph instance does not have the `sourcegraph/sourcegraph` repository, nothing happens. One idea was to make the search request against `sourcegraph.com/.api/search`, but I'm not sure if reaching out to sourcegraph.com is allowed in the context of a self-hosted instance. I imagine this is more a nice-to-have than anything, and will be most useful in the context of Sourcegraph Cloud and dogfood/staging environments where the `sourcegraph/sourcegraph` repo will be present. Co-authored-by: Erik Seliger <erikseliger@me.com>
`sg lint [target]` commands don't use args, and neither does `sg lint`, so we just enforce it by adding validation to provide helpful messages (right now commands like `sg lint docker go` run but the additional arg doesn't do anything) and simplify `runCheckScriptsAndReport`. linters should use flags exclusively to accept options in `lint.Target`
…ph#32219) * code monitoring: add url validation for slack and webhooks * simplify slack match
… update (sourcegraph#32278) * Add validation at API level for relevant mutations
It's not a fatal error and is leading to an increase in error metrics.
…ourcegraph#32255) * Small accessibility improvements for homepage user invites * Remove leftover console log * Use p-0 over padding: 0 class
This commit adds keybindings to the Notepad entry list: - Arrow up/down selects the next/previous item in the list. - Shift + Arrow up/down adds or removes the next/previous deselected item to the selection. - CTRL+a selects all items. - Delete/Backspace removes all selected items. - ESC deselects all selected items. For any of these to work, the list or an element within it must have focus. I had difficulties getting the the Shift-arrow up/down behavior right until I treated shift+arrow and shift+click as two different user interactions. I also changed how selected items are being represented from using a list of selected entry IDs to a list of indexes. This requires some additional bookkeeping when items are added or removed. I removed the background color change on hover to hopefully avoid that people think that any keybindings (but delete in particular) would interact with hovered items.
…th integration tests (sourcegraph#31572) * Add GitHub search pages enhancements integration tests * Configure git-lfs for *.har files (sourcegraph#31624)
…Org Code Host Connection (sourcegraph#32058)" (sourcegraph#32252)" (sourcegraph#32254) This reverts commit 5a9a429.
…ellify` packages (sourcegraph#32241) * fix: unit tests in client/common client/codeintellify * chore: decrease TOOLTIP_DISPLAY_DELAY Co-authored-by: gitstart-sourcegraph <gitstart@users.noreply.github.com>
…raph#32455) Co-authored-by: gitstart-sourcegraph <gitstart@users.noreply.github.com>
…graph#32543) * Use wildcard Popover instead of floating-ui * Fix MenuList popover position prop
…rom the `branded` package (sourcegraph#32508) * feat: migrate from the reactstrap Form to branded Form Co-authored-by: gitstart-sourcegraph <gitstart@users.noreply.github.com>
This has been deprecated for a while. I can't find any references in docs to use it, so lets just remove it.
For a long time now we manually maintain our changelog. Test Plan: CI
…wser`, `client/branded` (sourcegraph#31991) codemod `<Icon />` on `client/wildcard`, `client/shared`, `client/browser`, `client/branded` Co-authored-by: gitstart-sourcegraph <gitstart@users.noreply.github.com>
* feat: implement Collapse implementation Co-authored-by: gitstart-sourcegraph <gitstart@users.noreply.github.com>
…lient/web/site-admin`, `client/web/search` (sourcegraph#32051) * codemod <Icon /> on client/search-ui, client/web/extensions, client/web/site-admin, client/web/search Co-authored-by: gitstart-sourcegraph <gitstart@users.noreply.github.com>
* docker: update alpine base image * minio: update to latest version
Fairly certain this hasn't been used in a long time. It isn't referenced anywhere. Test Plan: CI
This is a script we have shared directly with customers before to understand the scale of the monorepos. This now stores it in our repository and documents it under our monorepo documentation. Test Plan: ran git-stats on the sourcegraph repo. Note the links in the documentation will only work once this PR has landed.
This row is too crowded, and we need a better design solution before adding yet another button here.
* Update minimum version of docker compose supported * Update changelog
…#32147) Co-authored-by: Noah Santschi-Cooney <noah@santschi-cooney.ch>
… Timescale (sourcegraph#32616) * Allow postgres uid to be specified for the postgres docker image. Defaults to the existing values (999 / 99) * Switch codeinsights to vanilla postgres and preserve postgres uid * Fix build errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )