Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a sort of mission document #3

Merged
merged 4 commits into from
Mar 18, 2023
Merged

Create a sort of mission document #3

merged 4 commits into from
Mar 18, 2023

Conversation

jcbhmr
Copy link
Member

@jcbhmr jcbhmr commented Mar 18, 2023

@eitsupi does this seem like a good limited scope? Looking for a second opinion since you mentioned concerns about scope and what this @devcontainers-community thing should be

loosely based on ideas from #1

Copy link
Contributor

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! I wrote some of my opinions.

In particular, I think that Docker image distribution should not be considered first.
Some reasons below

  1. It is less flexible than installation by Feature, which allows any version to be installed on any image. For example, check the images for Julia repository1 and the discussion2.
  2. Unlike Features and Templates, which have an established distribution method, it must be built from a build system. It also requires a significant amount of effort to maintain, as regular builds are needed to keep up with upstream updates.

Footnotes

  1. https://github.com/julia-vscode/julia-devcontainer

  2. https://github.com/microsoft/vscode-dev-containers/issues/1114

@jcbhmr
Copy link
Member Author

jcbhmr commented Mar 18, 2023

I think that Docker image distribution should not be considered first. Unlike Features and Templates, which have an established distribution method, it must be built from a build system. It also requires a significant amount of effort to maintain, as regular builds are needed to keep up with upstream updates.

You're absolutely right. Thanks! ❤️

I do think that images are a sort of de-facto "preset" like you just punch in:

{ "image": "ghcr.io/octocat/images/my-awesome-env" }

and you're done! It also is really fast in comparison to literally rebuilding Python from source or whatever; point is I think this is a valuable future idea

But yeah you're 100% correct that it's difficult! The size of the devcontainers/images repo vs the devcontainers/features repo makes that really apparent! Definitely not the first thing to tackle.

Thanks for being a moderating voice of reason 🙏 i really appreciate your involvement

co-authored-by: eitsupi <ts1s1andn@gmail.com>
@jcbhmr jcbhmr merged commit 7702765 into main Mar 18, 2023
@jcbhmr jcbhmr deleted the jcbhmr-patch-1 branch March 18, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants