Skip to content

Commit

Permalink
Merge pull request #135 from stuartleeks/sl/fix-checks-name
Browse files Browse the repository at this point in the history
Add new step for PR checks
  • Loading branch information
stuartleeks authored Jun 8, 2022
2 parents 1f05d60 + bd1bc79 commit 31a44bb
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
22 changes: 21 additions & 1 deletion .github/workflows/ci_common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,30 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
# the name must be identical to the one received by the real job
sha: ${{ inputs.prHeadSha }}
name: "build, test, package"
name: "Build, test, publish / All succeeded"
status: "completed"
conclusion: "success"

pr-succeeded:
# simple no-op job to use as step for checks for PR checks
name: All succeeded
needs: # TODO - check what jobs need adding here
- build
- test-azdo
- test-gh-run-args
- test-gh-build-args
- test-gh-dockerfile-context
- test-gh-feature-docker-from-docker
- test-gh-docker-from-docker-non-root
- test-gh-docker-from-docker-root
- test-gh-skip-user-update
- test-compose-features
runs-on: ubuntu-latest
steps:
- name: Simple step
run: |
echo Done!
release:
name: Create release
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
# the name must be identical to the one received by the real job
sha: ${{ steps.check_command.outputs.prHeadSha }}
name: "build, test, package"
name: "Build, test, publish / All succeeded"
status: "completed"
conclusion: "success"

Expand Down

0 comments on commit 31a44bb

Please sign in to comment.