Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore removing compiled JavaScript from repo #209

Closed
stuartleeks opened this issue Feb 11, 2023 · 0 comments · Fixed by #210
Closed

Explore removing compiled JavaScript from repo #209

stuartleeks opened this issue Feb 11, 2023 · 0 comments · Fixed by #210

Comments

@stuartleeks
Copy link
Collaborator

In the current implementation, the ci action is referenced with tags that pull the main repo code. As a result, the compiled JavaScript needs to exist in the repo. However, this adds a required (local) build step when making changes and increases the number of conflicting changes across PRs.

The action for publishing dev container features uses https://github.com/JasonEtco/build-and-tag-action in the publishing step.

From a quick scan, this packages a compiled version of the code under the tag. If the same approach can be used here this would allow removal of the compiled output.

Action usage here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant