Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compiled JS content #210

Merged
merged 10 commits into from
Feb 23, 2023
Merged

Remove compiled JS content #210

merged 10 commits into from
Feb 23, 2023

Conversation

stuartleeks
Copy link
Collaborator

Closes #209

I explored https://github.com/JasonEtco/build-and-tag-action as referenced in #209, but the expectations didn't align with the structure in this repo (e.g. we have a run-main.js and run-post.js that we need to preserve rather than a single file)

In the end, I took the following steps:

  • remove the compiled code and add these folders to .gitignore
  • update the GH workflows that use the action in PR tests to compile the JS code before running
  • update the release flow to create a temporary branch with only the files needed for running the action, create a tag + release with the full version number, and push to the major.minor tag version
  • bumped the version from 0.2.x to 0.3.x. This prevents anyone referencing 0.2 (as per the docs) from picking this up until better validated - a future PR will update the docs

@stuartleeks stuartleeks requested a review from a team as a code owner February 22, 2023 11:55
@stuartleeks
Copy link
Collaborator Author

Successful PR build via ci_branch: https://github.com/devcontainers/ci/actions/runs/4242931637

Copy link
Collaborator

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Left a comment on moving tags. Otherwise LGTM.

scripts/gh-release.sh Show resolved Hide resolved
chrmarti
chrmarti previously approved these changes Feb 23, 2023
@stuartleeks
Copy link
Collaborator Author

Re-ran the branch-based build to test workflow changes: https://github.com/devcontainers/ci/actions/runs/4254367522

@stuartleeks stuartleeks merged commit 3852c34 into main Feb 23, 2023
@stuartleeks stuartleeks deleted the sl/remove-compiled-content branch February 23, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore removing compiled JavaScript from repo
2 participants