Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename temp local cli path to avoid clashes #177

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

stuartleeks
Copy link
Collaborator

Change the name for the path used to embed the CLI for dev/test purposes
to reduce the chance of conflicts with paths in user repos

@stuartleeks stuartleeks requested a review from a team as a code owner October 28, 2022 12:22
@stuartleeks
Copy link
Collaborator Author

For context, I used this action in a repo that had a cli folder and got the following error:

** Installing local cli
/usr/bin/bash -c cd cli && npm install && npm install -g
npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /home/runner/work/AzureTRE/AzureTRE/cli/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/home/runner/work/AzureTRE/AzureTRE/cli/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/[20](https://github.com/microsoft/AzureTRE/actions/runs/3345352131/jobs/5540769235#step:5:21)[22](https://github.com/microsoft/AzureTRE/actions/runs/3345352131/jobs/5540769235#step:5:23)-10-28T12_18_[24](https://github.com/microsoft/AzureTRE/actions/runs/3345352131/jobs/5540769235#step:5:25)_200Z-debug-0.log

npm ERR! code ENOENT
npm ERR! syscall open
npm ERR! path /home/runner/work/AzureTRE/AzureTRE/cli/package.json
npm ERR! errno -2
npm ERR! enoent ENOENT: no such file or directory, open '/home/runner/work/AzureTRE/AzureTRE/cli/package.json'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2022-10-[28](https://github.com/microsoft/AzureTRE/actions/runs/3345352131/jobs/5540769235#step:5:29)T12_18_24_200Z-debug-0.log

@stuartleeks
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/devcontainers/ci/actions/runs/3345387192

(in response to this comment from @stuartleeks)

Change the name for the path used to embed the CLI for dev/test purposes
to reduce the chance of conflicts with paths in user repos
@stuartleeks stuartleeks force-pushed the sl/rename-temp-cli-path branch from d9c8af4 to 3c45c92 Compare October 28, 2022 12:30
@stuartleeks
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/devcontainers/ci/actions/runs/3345448794

(in response to this comment from @stuartleeks)

chrmarti
chrmarti previously approved these changes Oct 28, 2022
@stuartleeks
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/devcontainers/ci/actions/runs/3345902204

(in response to this comment from @stuartleeks)

@chrmarti chrmarti self-requested a review October 28, 2022 14:07
@stuartleeks stuartleeks merged commit 3dcee0e into devcontainers:main Oct 28, 2022
@stuartleeks stuartleeks deleted the sl/rename-temp-cli-path branch October 28, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants