Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noCache option #199

Merged
merged 8 commits into from
Mar 2, 2023
Merged

Conversation

trxcllnt
Copy link
Contributor

Adds a noCache option to pass --no-cache down to @devcontainer/cli.

This PR should address the issue I mentioned here: devcontainers/cli#343 (comment)

@trxcllnt trxcllnt requested review from a team and stuartleeks as code owners January 28, 2023 23:36
@stuartleeks
Copy link
Collaborator

Hi @trxcllnt - thanks for the PR! Reading the discussion you linked to, I can see how this would be a useful option for CI builds to pick up the latest versions of features (especially if the CI images are pushed and used as an image cache for local dev!)

This repo contains both the GitHub action and Azure DevOps task, and we aim to keep parity between the two. Would you mind updating the AzDO task to also include the noCache option? (As an aside, this made me realise that we don't currently have a contrib doc, so I've started work on that in #201!)

@trxcllnt
Copy link
Contributor Author

trxcllnt commented Feb 5, 2023

@stuartleeks sure! I'm not familiar with Azure DevOps tasks, but I think I updated the right files. Let me know if there's anything else I should change.

@trxcllnt trxcllnt force-pushed the add-no-cache-option branch from 5713f0c to 349288f Compare February 5, 2023 05:20
Copy link
Collaborator

@stuartleeks stuartleeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trxcllnt! I've merged in the latest changes from main and updated the docs.

LGTM

@stuartleeks stuartleeks requested a review from chrmarti February 28, 2023 14:17
@stuartleeks
Copy link
Collaborator

/test 5c482b5

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/devcontainers/ci/actions/runs/4293925444

(in response to this comment from @stuartleeks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants