Pass env vars to `devcontainer up` #211

stuartleeks · 2023-02-22T14:30:26Z

Pass env vars to devcontainer up step
Add GitHub and AzDO tests
Tweak GH build dependencies
Add more detail to docs on env vars when using localEnv references in remoteEnv section of devcontainer.json

stuartleeks requested a review from a team as a code owner February 22, 2023 14:30

stuartleeks changed the title ~~Pass env vars to build/up steps~~ Pass env vars to devcontainer up Feb 22, 2023

stuartleeks force-pushed the sl/env-vars-on-build branch from 1d5c1f7 to 12fb563 Compare February 22, 2023 14:35

chrmarti previously approved these changes Feb 23, 2023

View reviewed changes

stuartleeks dismissed chrmarti’s stale review via b6ccfec February 23, 2023 10:35

stuartleeks force-pushed the sl/env-vars-on-build branch 2 times, most recently from e4d7c55 to cd95643 Compare February 23, 2023 10:38

chrmarti previously approved these changes Feb 23, 2023

View reviewed changes

stuartleeks mentioned this pull request Feb 23, 2023

Support Build & Setup Environment Variables #153

Closed

stuartleeks added 6 commits February 24, 2023 10:03

And env vars to build/up commands

77fa8b9

Add env-vars-on-post-create tests

73dc1e0

Fixup script path

8148a8d

Tidy up devcontainer.json

42338d4

Update test

903d684

Update AzDO test

61c30a3

stuartleeks dismissed chrmarti’s stale review via 61c30a3 February 24, 2023 10:07

stuartleeks force-pushed the sl/env-vars-on-build branch from 39f15dc to 61c30a3 Compare February 24, 2023 10:07

stuartleeks added 3 commits February 24, 2023 10:20

Update test after JS removal changes

841109c

fixup AzDO test references

338a115

Update docs on env vars

cc8b632

chrmarti approved these changes Feb 24, 2023

View reviewed changes

stuartleeks merged commit fb6a663 into main Feb 24, 2023

stuartleeks deleted the sl/env-vars-on-build branch February 24, 2023 14:07

Provide feedback