Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow prebuilding image without a Dockerfile #352

Merged
merged 6 commits into from
Jan 4, 2023

Conversation

joshspicer
Copy link
Member

resolves #106

@joshspicer joshspicer requested a review from a team as a code owner January 3, 2023 18:11
@joshspicer
Copy link
Member Author

joshspicer commented Jan 3, 2023

image

Dev Container:

// For format details, see https://aka.ms/devcontainer.json. For config options, see the
// README at: https://github.com/devcontainers/templates/tree/main/src/debian
{
        "name": "Debian",
        // Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
        "image": "mcr.microsoft.com/devcontainers/base:bullseye"

        // Features to add to the dev container. More info: https://containers.dev/features.
        // "features": {},

        // Use 'forwardPorts' to make a list of ports inside the container available locally.
        // "forwardPorts": [],

        // Configure tool-specific properties.
        // "customizations": {},

        // Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
        // "remoteUser": "root"
}

@joshspicer joshspicer changed the title Allow prebuliding image without a Dockerfile Allow prebuilding image without a Dockerfile Jan 3, 2023
@joshspicer joshspicer marked this pull request as draft January 3, 2023 19:37
@joshspicer joshspicer marked this pull request as ready for review January 3, 2023 22:54
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@samruddhikhandale samruddhikhandale merged commit b61f8dd into main Jan 4, 2023
@samruddhikhandale samruddhikhandale deleted the joshspicer/issue/106 branch January 4, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--platform and --push flags force the use of a Dockerfile even if features are referenced
3 participants