Implement optional default values in localEnv/containerEnv expansions #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this PR @leopoldsedev! Requesting reviews from @chrmarti @joshspicer and @edgonmsft. |
chrmarti
previously approved these changes
Aug 10, 2022
joshspicer
previously approved these changes
Aug 10, 2022
|
Thanks! (closing/opening to trigger the CI) |
chrmarti
approved these changes
Aug 11, 2022
|
Thanks @leopoldsedev ! |
mraarone
reviewed
Aug 15, 2022
There was a problem hiding this comment.
These changes sufficiently seek out and implement default values. There is an assumption that the user will only input a single extra split for colons, and there is no limitation on how many can be inputted. Perhaps this is taken care of elsewhere, but I do not see a maximum evaluateSingleVariable, "variable" length or limit on "parts".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #50 and might even close it.