Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli- docker-compose - swap of installation packages #848

Conversation

gauravsaini04
Copy link
Contributor

This pr is a solution to the following issue:
#826

Order of installations has been reversed as proposed as a solution to the issue

@gauravsaini04 gauravsaini04 requested a review from a team as a code owner June 18, 2024 08:02
src/spec-node/dockerCompose.ts Outdated Show resolved Hide resolved
src/spec-node/dockerCompose.ts Outdated Show resolved Hide resolved
src/spec-node/dockerCompose.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. Left a comment.

src/spec-node/dockerCompose.ts Outdated Show resolved Hide resolved
src/spec-node/dockerCompose.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@samruddhikhandale samruddhikhandale merged commit 9d8210b into devcontainers:main Jun 21, 2024
19 checks passed
@gauravsaini04 gauravsaini04 deleted the cli_swap_docker_compose_installation branch June 22, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should devcontainers/cli uses docker compose always instead docker-compose?
3 participants