Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli issue - Valid devcontainer.metadata can corrupt compose override file #904 #928

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cli issue - Valid devcontainer.metadata can corrupt compose override file #904 #928

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39028a3
cli issue - Valid devcontainer.metadata can corrupt compose override …
gauravsaini04 Nov 6, 2024
ddb0c0b
Merge branch 'main' into cli_issue_#904_solution
gauravsaini04 Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/spec-node/dockerCompose.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ while sleep 1 & wait $$!; do :; done", "-"${userEntrypoint.map(a => `, ${JSON.st
init: true` : ''}${user ? `
user: ${user}` : ''}${Object.keys(env).length ? `
environment:${Object.keys(env).map(key => `
- ${key}=${env[key]}`).join('')}` : ''}${mergedConfig.privileged ? `
- "${key}=${env[key].replace(/"/g, '\\"')}"`).join('')}` : ''}${mergedConfig.privileged ? `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the resulting value? Should we put the env[key] in quotes if the quotes the in the values are escaped.

Is it possible to add tests for this scenario?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are additional characters to escape in a double quoted string. I might be easier to use a single quoted string, though I'm not sure how a newline would be represented: https://www.yaml.info/learn/quote.html

privileged: true` : ''}${capAdd.length ? `
cap_add:${capAdd.map(cap => `
- ${cap}`).join('')}` : ''}${securityOpts.length ? `
Expand Down