feat: Uses cwd as default workspace folder #956
+83
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
I agree that this would make life easier and I don't understand why it wasn't by default |
chrmarti
requested changes
Feb 28, 2025
| @@ -507,7 +497,7 @@ function buildOptions(y: Argv) { | |||
| 'user-data-folder': { type: 'string', description: 'Host path to a directory that is intended to be persisted and share state between sessions.' }, | |||
| 'docker-path': { type: 'string', description: 'Docker CLI path.' }, | |||
| 'docker-compose-path': { type: 'string', description: 'Docker Compose CLI path.' }, | |||
| 'workspace-folder': { type: 'string', required: true, description: 'Workspace folder path. The devcontainer.json will be looked up relative to this path.' }, | |||
| 'workspace-folder': { type: 'string', description: 'Workspace folder path. The devcontainer.json will be looked up relative to this path.' }, | |||
There was a problem hiding this comment.
Mention that the current working directory is used by default. (Also in a few other places in this file.)
There was a problem hiding this comment.
Yes. I actually just moved the default to the yargs entirely, so no need to manually handle null.
ekwoka
force-pushed
the
default-workspace-folder
branch
from
292e231 to
4c2a428
Compare
And fixes broken test syntaxes
|
Guess I got a style thing to fix ☢️ |
|
CI doesn't seem to pick up the latest commit. Will close and reopen to trigger fresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically makes the equivalent of
--workspace-folder .the default.I'd imagine that this is 99% of use cases already, and those that need something else will know they need something else.
I think I covered all the commands this would apply to with the tests.