Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOL Python 3.8 #1241

Merged
merged 5 commits into from
Dec 18, 2024
Merged

EOL Python 3.8 #1241

merged 5 commits into from
Dec 18, 2024

Conversation

Kaniska244
Copy link
Contributor

@Kaniska244 Kaniska244 commented Nov 26, 2024 •
edited
Loading

Ref: #90

@Kaniska244 Kaniska244 marked this pull request as ready for review November 27, 2024 15:44
@Kaniska244 Kaniska244 requested a review from a team as a code owner November 27, 2024 15:44
ddoyle2017
ddoyle2017 requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall, but there's a missed 3.8 reference in the README

src/python/README.md Show resolved Hide resolved
ddoyle2017
ddoyle2017 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ddoyle2017 ddoyle2017 merged commit a00b2d5 into devcontainers:main Dec 18, 2024
2 checks passed
@ddoyle2017 ddoyle2017 mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoyle2017 ddoyle2017 ddoyle2017 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kaniska244 @ddoyle2017