Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update schema to equivalent of inlining "allOf" #93

Closed
chrmarti opened this issue Sep 8, 2022 · 1 comment
Closed

Update schema to equivalent of inlining "allOf" #93

chrmarti opened this issue Sep 8, 2022 · 1 comment
Assignees
@aeschli @chrmarti
Milestone
January 2023

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Sep 8, 2022

We previously used a script to do this: https://github.com/microsoft/vscode/blob/main/extensions/configuration-editing/build/inline-allOf.ts

@aeschli mentioned a new schema feature to achieve the same while avoiding duplication: "unevaluatedProperties".
@chrmarti chrmarti mentioned this issue Nov 22, 2022
Closed
4 tasks
@kieferrm kieferrm mentioned this issue Jan 2, 2023
Closed
19 tasks
chrmarti added a commit to microsoft/vscode that referenced this issue Jan 12, 2023
@chrmarti
Reference original schema (devcontainers/spec#93)
3843c75
@chrmarti
Copy link
Contributor Author

#167, microsoft/vscode#169857 and microsoft/vscode#171163.

This was referenced Jan 12, 2023
Closed
Closed
chrmarti added a commit to microsoft/vscode that referenced this issue Jan 12, 2023
@chrmarti
Reference original schema (devcontainers/spec#93)
b7f4d34
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 12, 2023
vscode: Reference original schema (devcontainers/spec#93)
39faba4 
Commit: b7f4d341341a957dc9029ce88a84a9a3e49ff128
@chrmarti chrmarti self-assigned this Jan 17, 2023
@chrmarti chrmarti added this to the January 2023 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeschli aeschli

@chrmarti chrmarti

Labels
None yet
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
2 participants
@aeschli @chrmarti