Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devContainerFeature.schema.json #152

Merged
merged 5 commits into from
Dec 20, 2022

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Dec 6, 2022

ref: #140

A schema generated from https://github.com/devcontainers/cli/blob/main/src/spec-configuration/containerFeaturesConfiguration.ts#L25-L72

An example of this JSON file "in the wild" can be found in the devcontainers/features repo.

Examples of this validation file being piped into a VS Code extension:

image

image

image

image

@joshspicer joshspicer requested a review from a team as a code owner December 6, 2022 20:20
@joshspicer joshspicer changed the title Create devContainerFeature.schema.json Create devContainerFeature.schema.json Dec 12, 2022
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Left a suggestion.

schemas/devContainerFeature.schema.json Show resolved Hide resolved
@joshspicer joshspicer requested a review from chrmarti December 13, 2022 21:17
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More suggestions for descriptions. :)

schemas/devContainerFeature.schema.json Show resolved Hide resolved
schemas/devContainerFeature.schema.json Show resolved Hide resolved
schemas/devContainerFeature.schema.json Show resolved Hide resolved
schemas/devContainerFeature.schema.json Show resolved Hide resolved
schemas/devContainerFeature.schema.json Show resolved Hide resolved
schemas/devContainerFeature.schema.json Show resolved Hide resolved
schemas/devContainerFeature.schema.json Show resolved Hide resolved
schemas/devContainerFeature.schema.json Outdated Show resolved Hide resolved
@joshspicer joshspicer requested a review from chrmarti December 19, 2022 16:46
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joshspicer joshspicer merged commit 94e4ca9 into main Dec 20, 2022
@joshspicer joshspicer deleted the joshspicer/schemas/devContainerFeature branch December 20, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants