Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proposal] Sharing code between Dev Container Features #209

Merged
merged 6 commits into from
Apr 18, 2023
Merged

[proposal] Sharing code between Dev Container Features #209

merged 6 commits into from
Apr 18, 2023

Conversation

joshspicer
Copy link
Member

ref: #129

@eitsupi eitsupi mentioned this pull request Mar 11, 2023
Open
@joshspicer joshspicer marked this pull request as ready for review March 13, 2023 17:42
@joshspicer joshspicer requested a review from a team as a code owner March 13, 2023 17:42
jkeech
jkeech reviewed Mar 13, 2023
View reviewed changes
proposals/features-library.md Outdated Show resolved Hide resolved
proposals/features-library.md Outdated Show resolved Hide resolved
chrmarti
chrmarti requested changes Mar 14, 2023
View reviewed changes
proposals/features-library.md Outdated Show resolved Hide resolved
bamurtaugh
bamurtaugh reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for putting this together! Very clear, and I think it's great to address this due to the motivations and feedback you mention. Only had very nit cleanup comments.

proposals/features-library.md Outdated Show resolved Hide resolved
proposals/features-library.md Outdated Show resolved Hide resolved
proposals/features-library.md Outdated Show resolved Hide resolved
@bamurtaugh bamurtaugh mentioned this pull request Mar 14, 2023
Closed
joshspicer and others added 2 commits March 16, 2023 15:06
@joshspicer @bamurtaugh
Apply suggestions from code review
073b3b0 
Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com>
@joshspicer
clarify
9dec55f
@jcbhmr jcbhmr mentioned this pull request Mar 20, 2023
Closed
4 tasks
chrmarti
chrmarti requested changes Mar 21, 2023
View reviewed changes
proposals/features-library.md Outdated Show resolved Hide resolved
proposals/features-library.md Outdated Show resolved Hide resolved
@joshspicer
Copy link
Member Author

📣 Open Questions

chrmarti
chrmarti requested changes Apr 4, 2023
View reviewed changes
proposals/features-library.md Outdated Show resolved Hide resolved
proposals/features-library.md Outdated Show resolved Hide resolved
@joshspicer joshspicer merged commit c47ebfa into main Apr 18, 2023
This was referenced May 1, 2023
Closed
Closed
@jcbhmr jcbhmr mentioned this pull request May 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkeech jkeech jkeech left review comments

@bamurtaugh bamurtaugh bamurtaugh left review comments

@chrmarti chrmarti chrmarti approved these changes

@thereeroyz thereeroyz thereeroyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshspicer @jkeech @chrmarti @bamurtaugh @thereeroyz