Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for default value in ${localEnv:...} and ${containerEnv:...} #64

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Allow for default value in ${localEnv:...} and ${containerEnv:...} #64

merged 2 commits into from
Aug 10, 2022

Conversation

chrmarti
Copy link
Contributor

No description provided.

@chrmarti chrmarti mentioned this pull request Jul 22, 2022
Closed
@chrmarti chrmarti requested a review from bamurtaugh July 22, 2022 09:34
bamurtaugh
bamurtaugh approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one typo separate to this change, otherwise LGTM!

docs/specs/devcontainerjson-reference.md Outdated Show resolved Hide resolved
jkeech
jkeech approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@jkeech jkeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chrmarti @bamurtaugh
Update docs/specs/devcontainerjson-reference.md
de822e7 
Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com>
@chrmarti chrmarti requested a review from a team as a code owner August 10, 2022 08:01
@chrmarti chrmarti merged commit 69d6e73 into main Aug 10, 2022
@chrmarti chrmarti deleted the chrmarti/strange-wolf branch August 10, 2022 08:02
@bamurtaugh bamurtaugh mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamurtaugh bamurtaugh bamurtaugh approved these changes

@joshspicer joshspicer joshspicer approved these changes

@jkeech jkeech jkeech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrmarti @jkeech @joshspicer @bamurtaugh