Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node templates: Add debian:bookworm options & remove the ones without OS bit #172

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Node templates: Add debian:bookworm options & remove the ones without OS bit #172

merged 4 commits into from
Jun 23, 2023

Conversation

samruddhikhandale
Copy link
Member

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner June 23, 2023 18:28
@samruddhikhandale samruddhikhandale changed the title Node templates: Support debian:bookworm Node templates: Add debian:bookworm options & remove the ones without OS bit Jun 23, 2023
joshspicer
joshspicer reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the dev container as is for now (or pin to bullseye)

@samruddhikhandale samruddhikhandale merged commit 6b6520c into main Jun 23, 2023
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/node-bookworm branch June 23, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshspicer joshspicer joshspicer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samruddhikhandale @joshspicer