Adjustments to the behavior of tracking entities in the EntityRepository

src/Deveel.Repository.EntityFramework/Data/EntityRepository.cs

@@ -110,6 +110,13 @@ internal EntityRepository(DbContext context, ITenantInfo? tenantInfo, ILogger? l
 		/// </summary>
         protected virtual DbSet<TEntity> Entities => Context.Set<TEntity>();
 
+		/// <summary>
+		/// Gets a value indicating if the repository is tracking the changes
+		/// to the entities returned by the queries.
+		/// </summary>
+		protected bool IsTrackingChanges => Entities.Local != null ||
+			Context.ChangeTracker.QueryTrackingBehavior != QueryTrackingBehavior.NoTracking;
+
 		/// <summary>
 		/// Gets the information about the tenant that the repository is using to access the data.
 		/// </summary>
@@ -324,7 +331,17 @@ public virtual async Task<bool> UpdateAsync(TEntity entity, CancellationToken ca
 
 				Logger.TraceUpdatingEntity(typeof(TEntity), entityId, TenantId);
 
-				var entry = Context.Entry(entity);
+				if (!IsTrackingChanges) {
+					var existing = await FindByKeyAsync(entityId, cancellationToken);
+					if (existing == null) {
+						Logger.WarnEntityNotFound(typeof(TEntity), entityId, TenantId);
+						return false;
+					}
+
+					var entry = Context.Entry(existing);
+					entry.CurrentValues.SetValues(entity);
+					entry.State = EntityState.Modified;
+				}
 
 				var count = await Context.SaveChangesAsync(cancellationToken);
 

src/Deveel.Repository.Manager/Data/EntityManager.cs

@@ -14,6 +14,7 @@
 
 using System.ComponentModel.DataAnnotations;
 using System.Linq.Expressions;
+using System.Runtime.CompilerServices;
 
 using Deveel.Data.Caching;
 

src/Deveel.Repository.Manager/OperationResult_1.cs

@@ -156,6 +156,15 @@ public static implicit operator OperationResult<TValue>(TValue value)
 		public static implicit operator OperationResult<TValue>(OperationResult result)
 			=> new(result.ResultType, default, result.Error);
 
+		/// <summary>
+		/// Implicitly converts the given <paramref name="result"/>
+		/// to the value returned by the operation.
+		/// </summary>
+		/// <param name="result">
+		/// The operation result that is to be converted.
+		/// </param>
+		public static implicit operator TValue?(OperationResult<TValue> result) => result.Value;
+
 		/// <summary>
 		/// Creates a result that indicates a successful operation.
 		/// </summary>

test/Deveel.Repository.EntityFramework.XUnit/Data/EntityRepositoryTestSuite.cs

@@ -40,7 +40,7 @@ protected override Task RemoveRelationshipAsync(DbPerson person, DbRelationship
 
 		protected override void ConfigureServices(IServiceCollection services) {
 			services.AddDbContext<DbContext, PersonDbContext>(builder => {
-				builder.UseQueryTrackingBehavior(QueryTrackingBehavior.NoTrackingWithIdentityResolution);
+				builder.UseQueryTrackingBehavior(QueryTrackingBehavior.NoTracking);
 				builder.UseSqlite(sql.Connection, sqlite => {
 					sqlite.UseNetTopologySuite();
 				});

test/Deveel.Repository.Manager.XUnit/Data/EntityManagerTestSuite_1.cs

@@ -139,7 +139,7 @@ public async Task AddRangeOfEntities_InvalidEmail() {
 		}
 
 		[Fact]
-		public async Task UpdateEntity() {
+		public virtual async Task UpdateEntity() {
 			var person = People.Random()!;
 
 			var copy = new Person {
@@ -152,6 +152,7 @@ public async Task UpdateEntity() {
 			};
 
 			var result = await Manager.UpdateAsync(copy);
+
 			Assert.False(result.IsValidationError());
 			Assert.True(result.IsSuccess());
 

test/Deveel.Repository.Manager.XUnit/OperationResultTests.cs

@@ -216,6 +216,37 @@ public static void ImplicitConvertResultValue_Success() {
 			Assert.Equal(value, result.Value);
 		}
 
+		[Fact]
+		public static void ImplicitConvertResultValue_ToValue() {
+			var success = OperationResult<int>.Success(22);
+
+			int value = success;
+
+			Assert.Equal(22, value);
+		}
+
+		[Fact]
+		public static void ImplicitConvertResultValue_FromSuccessOperationResult() {
+			var success = OperationResult.Success;
+
+			var result = (OperationResult<int>) success;
+
+			Assert.Equal(OperationResultType.Success, result.ResultType);
+			Assert.Equal(default, result.Value);
+			Assert.Null(result.Error);
+		}
+
+		[Fact]
+		public static void ImplicitConvertResultValue_FromFailOperationResult() {
+			var fail = OperationResult.Fail("ERROR_CODE", "An error has occurred");
+
+			var result = (OperationResult<int>)fail;
+
+			Assert.Equal(OperationResultType.Error, result.ResultType);
+			Assert.Equal(default, result.Value);
+			Assert.NotNull(result.Error);
+		}
+
 		[Fact]
 		public static async Task MapValueAsync() {
 			var result = OperationResult<string>.Success("test");