fix: hoist dependencies to the real parent (#118)

develar · Jul 4, 2024 · 94485c6 · 94485c6
1 parent ea95e30
commit 94485c6
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/.changeset/tasty-houses-drum.md b/.changeset/tasty-houses-drum.md
@@ -0,0 +1,5 @@
+---
+"app-builder-bin": patch
+---
+
+fix: hoist dependencies to the real parent in nodeModuleCollector
diff --git a/pkg/node-modules/nodeModuleCollector.go b/pkg/node-modules/nodeModuleCollector.go
@@ -214,6 +214,19 @@ func (t *Collector) resolveDependency(parentNodeModuleDir string, name string) (
  if realParentNodeModuleDir == "" {
  return nil, nil
  }
+
+ // XXX consumers expect the node_modules shape or the dependency tree ?
+ // hoist the depends to the actual parent
+ if realParentNodeModuleDir != parentNodeModuleDir {
+ dependencyNameToDependency = t.NodeModuleDirToDependencyMap[realParentNodeModuleDir]
+ if dependencyNameToDependency != nil {
+ dependency := (*dependencyNameToDependency)[name]
+ if dependency != nil {
+ return nil, nil
+ }
+ }
+ }
+
  dependencyDir := filepath.Join(realParentNodeModuleDir, name)
  dependency, err := readPackageJson(dependencyDir)
  if err != nil {