Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix electron-userland/electron-builder#8431
package.json
main.js
error
root cause
The version of
minipass
in theminizlib
dependency is incorrect; it shouldn't be 3.3.6.Currently, there's no record of the parent-child tree relationship, and it doesn't search for the highest parent node. If it's already found, it directly returns
nil
, causing it to revert to an older version.How to fix
Perform a fixed-order loop search on the
NodeModuleDirToDependencyMap
. If the dependency is in thehoistedDependMap
and the version number is different, place that dependency in theconflictDependencyMap
of the highest parent node. If it's not in thehoistedDependMap
, just set it directly.The current approach is to implement a
hoistedDependMap
, so it's no longer necessary to setnode-linker=hoisted
in pnpm's configuration.