fix: Creating an MSI on Windows fails

Close electron-userland#485
develar · Jun 23, 2016 · 4e2ccc6 · 4e2ccc6
1 parent b192fc1
commit 4e2ccc6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -68,7 +68,7 @@
     "deep-assign": "^2.0.0",
     "electron-osx-sign-tf": "0.6.0",
     "electron-packager-tf": "~7.4.0",
-    "electron-winstaller-fixed": "~2.10.2",
+    "electron-winstaller-fixed": "~2.11.0",
     "fs-extra-p": "^1.0.3",
     "hosted-git-info": "^2.1.5",
     "image-size": "^0.5.0",

diff --git a/src/targets/squirrelWindows.ts b/src/targets/squirrelWindows.ts
@@ -67,6 +67,7 @@ export default class SquirrelWindowsTarget extends Target {
       productName: appInfo.productName,
       exe: `${appInfo.productName}.exe`,
       setupExe: setupExeName,
+      msiExe: setupExeName.replace(".exe", ".msi"),
       title: appInfo.productName,
       appDirectory: appOutDir,
       outputDirectory: installerOutDir,

diff --git a/test/src/winPackagerTest.ts b/test/src/winPackagerTest.ts
@@ -54,12 +54,13 @@ test.ifNotCiOsx("nsis boring", () => assertPack("test-app-one", _signed({
 // ))
 
 // very slow
-test.ifWinCi("delta", () => assertPack("test-app-one", {
+test.ifWinCi("delta and msi", () => assertPack("test-app-one", {
     targets: Platform.WINDOWS.createTarget(null, Arch.ia32),
     devMetadata: {
       build: {
         win: {
           remoteReleases: "https://github.com/develar/__test-app-releases",
+          msi: true,
         }
       }
     },