Skip to content

Commit

Permalink
Review-related fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Kirill Saksin committed Sep 20, 2019
1 parent bc4bd44 commit 346c09c
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 24 deletions.
24 changes: 4 additions & 20 deletions README.en.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,25 +30,9 @@ We encourage our colleagues not to stand aside and to support this letter.

# How to sign

You can do this by creating a file with a random name (preferably complex) in the `signed` folder. Put the following lines in the file (each line is a separate person):
You can sign this letter by creating file with random name in `signed` directory.
Put the following lines in the file (each line represents a single person):
```
Last Name First Name | Position, company
Name Surname | Position, company
```

## Linux / MacOS / Cygwin (git bash)

```bash
# Here YOUR_FORK - your fork of this repository
git clone ${YOUR_FORK}
cd case-212
# YOUR_GITHUB_USERNAME - username on github, such naming of branch is optional,
# you can name your branch however you want, but don't forget to change git push command as well!
git checkout -b signature/${YOUR_GITHUB_USERNAME}
cd signed
# YOUR_SURNAME - surname, YOUR_NAME - first name, POSITION - position at your company, COMPANY - your company
echo "${YOUR_SURNAME} ${YOUR_NAME} | ${POSITION}, ${COMPANY}" > $(uuidgen)
git commit -a -m 'Signature from ${YOUR_GITGUB_USERNAME}'
git push origin signature/${YOUR_GITHUB_USERNAME}
# time to create pull-request!
```

More verbose manual is available [here](./manual.en.md)
6 changes: 3 additions & 3 deletions manual.en.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# How to sign

You can do this by creating a file with a random name (preferably complex) in the `signed` folder. Put the following lines in the file (each line is a separate person):
You can sign this letter by creating a file with a random name (an easy way to create a unique filename is to use *[GUID generator](https://www.guidgenerator.com/online-guid-generator.aspx)*) in the `signed` folder. Put the following lines in the file (each line represents a single person):
```
Last Name First Name | Position, company
Name Surname | Position, company
```

## Linux / MacOS / Cygwin (git bash)
Expand All @@ -16,7 +16,7 @@ cd case-212
git checkout -b signature/${YOUR_GITHUB_USERNAME}
cd signed
# YOUR_SURNAME - surname, YOUR_NAME - first name, POSITION - position at your company, COMPANY - your company
echo "${YOUR_SURNAME} ${YOUR_NAME} | ${POSITION}, ${COMPANY}" > $(uuidgen)
echo "${YOUR_NAME} ${YOUR_SURNAME} | ${POSITION}, ${COMPANY}" > $(uuidgen)
git commit -a -m 'Signature from ${YOUR_GITHUB_USERNAME}'
git push origin signature/${YOUR_GITHUB_USERNAME}
# time to create pull-request!
Expand Down
7 changes: 6 additions & 1 deletion pre-readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@

# Как подписаться

Смотрите [инструкцию](./manual.md)
Вы можете оставить подпись создав файл со случайным именем в директории `signed`.
В этом файле напишите строки следующего формата (каждая строка отдельный человек):
```
Фамилия Имя | Должность, компания
```
Более подробная инструкция доступна [здесь](./manual.md)

***

Expand Down

0 comments on commit 346c09c

Please sign in to comment.