fix the banner image, meetup listing meetup-15, meetup-16 #45
Conversation
|
looks like needs a rebase |
|
Review it please and when ready can be merged. |
| @@ -1,8 +1,8 @@ | |||
| --- | |||
| layout: meetup | |||
| title: "Meetup #15 - 16 Jan 2016" | |||
| title: "Meetup #15 - Coming 16 Jan 2016" | |||
There was a problem hiding this comment.
no it's ok that was me who removed Coming and then again added it back :)
There was a problem hiding this comment.
maybe we should add a logic if the date is in the future, the name attaches UPCOMING automatically. That is much better than this.
It should be somewhere in this file IMO https://github.com/developers-nepal/php/blob/gh-pages/_layouts/meetup.html
There was a problem hiding this comment.
I thnk it is an overkill for now :) let's do the bare minimum.
There was a problem hiding this comment.
I also think it's overkill for now. It should have worked with the existing code base but looks like we missed something. I will look into this more maybe sometime this weekend. 🆗
|
I have fixed the issue. The page now appears on the list. For now I have removed |
| @@ -10,4 +10,7 @@ | |||
| <div align="center"> | |||
| <img src="{{ site.baseurl }}/public/images/dn-icon.gif" | |||
| alt="Developers Nepal Community"> | |||
| <br/> | |||
| <small>Last updated date {{ site.time | date: "%A, %b %d, %Y" }}</small> | |||
There was a problem hiding this comment.
I have added last page update time just above the footer.
samundra
changed the title
| @@ -14,7 +14,6 @@ | |||
| </div> | |||
|
|
|||
| {% include footer.html %} | |||
|
|
|||
| <!-- <small>Last generated on : {{ site.time }}</small> --> | |||
There was a problem hiding this comment.
can we remove this comment ?
|
merging this, then I will fix the commented code issue in |
No description provided.