User registration styling #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 12, 2018 13:10
# Conflicts: # templates/base.html
ikonitas
reviewed
Mar 14, 2018
static/src/js/form.jsx
Outdated
| @@ -0,0 +1,103 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Can we change this path into something else to be more recognizable for what it is? Example src/apps/accounts/registration.jsx ?
|
added 9 commits
March 14, 2018 20:44
# Conflicts: # static/src/scss/_variables.scss # static/src/scss/styles.scss # templates/test.html
|
@richpeters not sure whats going on here but pages aren't loading? |
|
|
Webpack Node SASS known issue. end runserver process, start again, save .scss file, refresh page |
|
|
Can I get the URL to the known issue for the webpack? |
|
webpack-contrib/sass-loader#100 has something to do with importing files. Suggested that you use |
# Conflicts: # apps/accounts/forms.py # apps/accounts/urls.py # static/src/scss/_resources.scss # static/src/scss/global/_navigation.scss # static/src/scss/styles.scss # templates/base.html # templates/group.html # templates/includes/header.html # templates/profile.html # templates/test.html # webpack.config.js # webpack.production.js
tomkins
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.