-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated all examples to latest OpenAI package with new syntax, plus other upgrades #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate your help in bringing things up to date. I made a few minor comments.
In the future (here and on other projects), more bite sized PRs are usually easier to review (and revert, if anything goes wrong). For example, this one may have been broken into one for each of: moving to vite, upgrading openai usage, introducing dotenv, upgrading packages, and other cleanup.
Again, thank you for helping bring things up to date.
- Starting with step 3, start the python backend with `uvicorn api:app --reload` | ||
- (For 4-6) run `npm install` then `npm run dev` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer the same phrasing between "Starting with step 3" and "(For 4-6)" but no preference as to which format is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you'd prefer the original phrasing (but with npm run dev
) then that's fine. I can remove the "Starting with step 3, " text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your feedback. I'll look into the best workflow for taking a whole bunch of commits and breaking them down into separate PRs, because you're right that PRs should have a single focus.
- Starting with step 3, start the python backend with `uvicorn api:app --reload` | ||
- (For 4-6) run `npm install` then `npm run dev` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you'd prefer the original phrasing (but with npm run dev
) then that's fine. I can remove the "Starting with step 3, " text
Here are some of the major changes in this PR:
.env
support in lieu of system environment variables to make it more beginner friendly along with a.env.example
fileMinor quality of life enhancements
requirements.txt
packages to the latest versions, and tested/03_api
to help someone try out aGET
request with one click to the browser.gitignore
inconsistences