Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Edge, Safari #38

Merged
merged 5 commits into from
Oct 1, 2019
Merged

Conversation

spkellydev
Copy link
Contributor

@spkellydev spkellydev commented Mar 4, 2019

Edge throws a SecurityError when the function is inlined. Additionally, Edge doesn't have support for ImageBitmap. I didn't see any reason why the library should support ImageBitmap other than a small performance boost for supported browsers. Supporting Edge, I think, should be more of a priority than a possible performance boost for the other browsers.

Creating a blob object URL for the function will bypass the Edge security monitors and provides the same async/await functionality the library is designed for! This merge would resolve #34 let me know what you think!

Codesandbox link: https://codesandbox.io/s/p5ro71xxpm

@spkellydev
Copy link
Contributor Author

It looks like the CI pipeline fails when webpack is not in package.json. Webpack was moved out of karmatic dependenices in Jun 2018

greenlet.js Outdated Show resolved Hide resolved
greenlet.js Outdated Show resolved Hide resolved
@TimvanScherpenzeel
Copy link

TimvanScherpenzeel commented Mar 11, 2019

Perhaps beyond the scope of this PR but I've noticed that JSFiddle in the README does not work on iOS Safari. It appears to not log anything: https://jsfiddle.net/developit/mf9fbma5/. I'm unsure why as it appears to create the worker without any issue.

Edit:

I've looked a bit more into it and it appears that the onmessage event in the Worker is never fired on iOS Safari. Safari on desktop works fine however.

Edit:

After looking more into it this morning and physically connection the device it works fine now. So never mind my comments about iOS Safari.

@spkellydev
Copy link
Contributor Author

Any status on this PR?

@developit
Copy link
Owner

Sorry for the slow response @TimvanScherpenzeel.

@spkellydev
Copy link
Contributor Author

Anything I can do to help with this PR?

@developit
Copy link
Owner

developit commented Oct 1, 2019

Nothing on your part, sorry for the delay! I've finally had a chance to look through the history here and I think we're okay to go back to blobs.

The build errors are just coverage breaking, I'll fix that on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge issue. SCRIPT5022: SecurityError
3 participants