Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repository directory #70

Merged
merged 4 commits into from
Apr 7, 2019
Merged

Add repository directory #70

merged 4 commits into from
Apr 7, 2019

Conversation

styfle
Copy link
Contributor

@styfle styfle commented Feb 25, 2019 •
edited
Loading

developit
developit approved these changes Feb 26, 2019
View reviewed changes
Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, TIL

@styfle
Copy link
Contributor Author

styfle commented Feb 26, 2019

Also note that react and react-dom are using this feature already.

See this PR: facebook/react#14628

@developit developit merged commit 82d1545 into developit:master Apr 7, 2019
@styfle styfle deleted the patch-1 branch April 7, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@styfle @developit