feat: Expands generateTypes flag to support TS entries (#865)

* feat: Expands generateTypes flag to support TS entries * fix: Returning previous .d.ts generation * test: Modifying `--generateTypes false` test for use on TS projects * docs: Adding changeset
developit · Oct 6, 2021 · 2980336 · 2980336
1 parent 76272fd
commit 2980336
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 4 deletions.
diff --git a/.changeset/slimy-roses-explain.md b/.changeset/slimy-roses-explain.md
@@ -0,0 +1,5 @@
+---
+'microbundle': patch
+---
+
+Expands generateTypes flag to support libs with TS entrypoints
diff --git a/src/index.js b/src/index.js
@@ -524,10 +524,12 @@ function createConfig(options, entry, format, writeMeta) {
 							tsconfigDefaults: {
 								compilerOptions: {
 									sourceMap: options.sourcemap,
-									declaration: true,
+									declaration: options.generateTypes !== false,
 									allowJs: true,
 									emitDeclarationOnly: options.generateTypes && !useTypescript,
-									declarationDir: getDeclarationDir({ options, pkg }),
+									...(options.generateTypes !== false && {
+										declarationDir: getDeclarationDir({ options, pkg }),
+									}),
 									jsx: 'preserve',
 									jsxFactory:
 										// TypeScript fails to resolve Fragments when jsxFactory

diff --git a/test/__snapshots__/index.test.js.snap b/test/__snapshots__/index.test.js.snap
@@ -2730,9 +2730,10 @@ ts-custom-declaration
     index.js.map
     index.umd.js
     index.umd.js.map
+  node_modules
   package.json
   src
-    index.js
+    index.ts
   tsconfig.json
   types
     index.d.ts

diff --git a/test/fixtures/ts-custom-declaration/package.json b/test/fixtures/ts-custom-declaration/package.json
@@ -2,7 +2,7 @@
 	"name": "ts-custom-declarations",
 	"main": "dist/index.js",
 	"types": "types/index.d.ts",
-	"source": "src/index.js",
+	"source": "src/index.ts",
   "scripts": {
     "build": "microbundle --generateTypes false"
   }

diff --git a/...xtures/ts-custom-declaration/src/index.js → ...xtures/ts-custom-declaration/src/index.ts b/...xtures/ts-custom-declaration/src/index.js → ...xtures/ts-custom-declaration/src/index.ts