Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto installing buggy @rollup/plugin-commonjs - v1.11.0 #626

Closed
wants to merge 1 commit into from

Conversation

mihilranathunga
Copy link

@marvinhagemeister
Copy link
Collaborator

Looks like a new version of that plugin is out which includes the fix for the linked issue. I think instead of limiting the install range it'd be better if we just upgrade to that. What do you think?

@developit
Copy link
Owner

I agree with upgrading to 12, though I believe it still has some of the issues present in 11.1.

@mihilranathunga
Copy link
Author

yes please, upgrade to the latest. Will close this.

@jakewies
Copy link

This is still an issue for me. It looks like microbundle is still installing buggy @rollup/plugin-commonjs v11.1.0.

@marvinhagemeister
Copy link
Collaborator

@jakewies Looks like there hasn't been a release published since the fix was merged.

@developit Should we cut a new release?

@developit
Copy link
Owner

Yup - just published 0.12.1 with this fix!

@jakewies
Copy link

@developit @marvinhagemeister not sure if 0.12.1 included this fix. Am I missing something? 😅

@developit
Copy link
Owner

Fix incoming, apologies.

developit added a commit that referenced this pull request Jun 15, 2020
@developit developit mentioned this pull request Jun 15, 2020
@jakewies
Copy link

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'import' and 'export' may only appear at the top level
4 participants