Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: css compilation problems when multiple entries #961

Merged
merged 4 commits into from
Jun 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-worms-smell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'microbundle': patch
---

Fix for when multiple entries reference different CSS, only the CSS referenced by the first entry will be packaged
9 changes: 2 additions & 7 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,7 @@ export default async function microbundle(inputOptions) {
for (let i = 0; i < options.entries.length; i++) {
for (let j = 0; j < formats.length; j++) {
steps.push(
createConfig(
options,
options.entries[i],
formats[j],
i === 0 && j === 0,
),
createConfig(options, options.entries[i], formats[j], j === 0),
);
}
}
Expand Down Expand Up @@ -502,7 +497,7 @@ function createConfig(options, entry, format, writeMeta) {
extract:
!!writeMeta &&
options.css !== 'inline' &&
options.output.replace(EXTENSION, '.css'),
absMain.replace(EXTENSION, '.css'),
minimize: options.compress,
sourceMap: options.sourcemap && options.css !== 'inline',
}),
Expand Down
93 changes: 93 additions & 0 deletions test/__snapshots__/index.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,99 @@ exports[`fixtures build basic-multi-source with microbundle 8`] = `
"
`;

exports[`fixtures build basic-multi-source-css with microbundle 1`] = `
"Used script: microbundle

Directory tree:

basic-multi-source-css
a.css
a.js
b.css
b.js
dist
a.css
a.css.map
a.esm.mjs
a.esm.mjs.map
a.js
a.js.map
a.umd.js
a.umd.js.map
b.css
b.css.map
b.esm.mjs
b.esm.mjs.map
b.js
b.js.map
b.umd.js
b.umd.js.map
package.json


Build \\"basic-multi-source-css\\" to dist:
104 B: a.js.gz
61 B: a.js.br
105 B: a.esm.mjs.gz
67 B: a.esm.mjs.br
201 B: a.umd.js.gz
133 B: a.umd.js.br
104 B: b.js.gz
61 B: b.js.br
106 B: b.esm.mjs.gz
67 B: b.esm.mjs.br
201 B: b.umd.js.gz
134 B: b.umd.js.br"
`;

exports[`fixtures build basic-multi-source-css with microbundle 2`] = `16`;

exports[`fixtures build basic-multi-source-css with microbundle 3`] = `
".a{display:flex;color:green;background:pink}
/*# sourceMappingURL=a.css.map */"
`;

exports[`fixtures build basic-multi-source-css with microbundle 4`] = `
"function e(){var e=document.createElement(\\"div\\");return e.className=\\"a\\",e}export default e;
//# sourceMappingURL=a.esm.mjs.map
"
`;

exports[`fixtures build basic-multi-source-css with microbundle 5`] = `
"module.exports=function(){var e=document.createElement(\\"div\\");return e.className=\\"a\\",e};
//# sourceMappingURL=a.js.map
"
`;

exports[`fixtures build basic-multi-source-css with microbundle 6`] = `
"!function(e,n){\\"object\\"==typeof exports&&\\"undefined\\"!=typeof module?module.exports=n():\\"function\\"==typeof define&&define.amd?define(n):(e||self).basicMultiSourceCss=n()}(this,function(){return function(){var e=document.createElement(\\"div\\");return e.className=\\"a\\",e}});
//# sourceMappingURL=a.umd.js.map
"
`;

exports[`fixtures build basic-multi-source-css with microbundle 7`] = `
".b{display:flex;color:red;background:#00f}
/*# sourceMappingURL=b.css.map */"
`;

exports[`fixtures build basic-multi-source-css with microbundle 8`] = `
"function e(){var e=document.createElement(\\"div\\");return e.className=\\"b\\",e}export default e;
//# sourceMappingURL=b.esm.mjs.map
"
`;

exports[`fixtures build basic-multi-source-css with microbundle 9`] = `
"module.exports=function(){var e=document.createElement(\\"div\\");return e.className=\\"b\\",e};
//# sourceMappingURL=b.js.map
"
`;

exports[`fixtures build basic-multi-source-css with microbundle 10`] = `
"!function(e,n){\\"object\\"==typeof exports&&\\"undefined\\"!=typeof module?module.exports=n():\\"function\\"==typeof define&&define.amd?define(n):(e||self).basicMultiSourceCss=n()}(this,function(){return function(){var e=document.createElement(\\"div\\");return e.className=\\"b\\",e}});
//# sourceMappingURL=b.umd.js.map
"
`;

exports[`fixtures build basic-no-compress with microbundle 1`] = `
"Used script: microbundle --no-compress

Expand Down
5 changes: 5 additions & 0 deletions test/fixtures/basic-multi-source-css/a.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.a {
display: flex;
color: green;
background: pink;
}
7 changes: 7 additions & 0 deletions test/fixtures/basic-multi-source-css/a.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import './a.css';

export default function () {
const el = document.createElement('div');
el.className = 'a';
return el;
}
5 changes: 5 additions & 0 deletions test/fixtures/basic-multi-source-css/b.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
.b {
display: flex;
color: red;
background: blue;
}
7 changes: 7 additions & 0 deletions test/fixtures/basic-multi-source-css/b.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import './b.css';

export default function () {
const el = document.createElement('div');
el.className = 'b';
return el;
}
7 changes: 7 additions & 0 deletions test/fixtures/basic-multi-source-css/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "basic-multi-source-css",
"source":[
"./a.js",
"./b.js"
]
}