-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stronger typing #114
Stronger typing #114
Conversation
I suppose this could also leverage on module augmentation / declaration merging to allow typings for different events to be declared across different files as well? See #97 (comment) |
Hi @developit, could you please give some feedback on this PR? |
HI @developit, could you merge this pull request? |
Since this repo looks abandoned, I put my fork to npm as |
@iyegoroff is the repo abandoned or just maybe @developit is super busy atm ? |
@y-nk the latter - getting this stuff landed and doing some repo maintenance just bubbled up to the top of my to-do list though. |
Thanks a lot @developit ! If you need any help/assitance let me know i'd be glad to help. |
Alright, I had a chance to play around with this and it's pretty great! |
This PR improves type inference for instance methods when
"strict": true
is present in tsconfig.json. Compiled js code isn't affected by this change, only typings.fixes #112
fixes #106