-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If emitter.off provides only the event, remove all listeners for that event. #124
Conversation
If emitter.off provides only the event, remove all listeners for that event.
Looks like this needs some formatting fixes and it should be good to go! |
@andreyrd Thanks, I am going to fix the format. |
Quick note, could this be adjusted to allow for partial/wildcard matching? So we can remove listeners written in a namespaced format.
Which could then be used to remove all listeners for a component on destroy, rather than listing each one, potentially missing some. I'm happy to add the code myself if needed in another PR. |
This is a good idea, you are welcome to submit your own ideas. |
what happened to this PR awaiting for this feature |
@developit ping & thanks |
This will be released as 3.0.0. |
This solves the #123 issue.