-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full TypeScript definitions and export them, add basic TS tests. #159
Conversation
Size Change: 0 B Total Size: 1.06 kB ℹ️ View Unchanged
|
Hi there, I don't know if this something have to do with this fix, but since I use the latest version I get eslint errors. I'm using fetch like this this in my projects:
Since the update I get: ESLint: No default export found in imported module "isomorphic-unfetch".(import/default) |
hey @kolorfilm - thanks for the ping, I had forgotten to remove the |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [unfetch](https://togithub.com/developit/unfetch) | [`4.2.0` -> `5.0.0`](https://renovatebot.com/diffs/npm/unfetch/4.2.0/5.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/unfetch/5.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/unfetch/5.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/unfetch/4.2.0/5.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/unfetch/4.2.0/5.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>developit/unfetch (unfetch)</summary> ### [`v5.0.0`](https://togithub.com/developit/unfetch/releases/tag/5.0.0) [Compare Source](https://togithub.com/developit/unfetch/compare/4.2.0...5.0.0) #### What's Changed - Add TypeScript definitions and export them [@​developit](https://togithub.com/developit) in [https://github.com/developit/unfetch/pull/159](https://togithub.com/developit/unfetch/pull/159) - Add [Package Exports](https://togithub.com/developit/unfetch/blob/ed9469aab15e2cd8c243995a8ba964599467e413/package.json#L16-L26) to both unfetch and isomorphic-unfetch #### New Contributors - [@​RishikeshDarandale](https://togithub.com/RishikeshDarandale) made their first contribution to isomorphic-unfetch in [https://github.com/developit/unfetch/pull/156](https://togithub.com/developit/unfetch/pull/156) **Full Changelog**: developit/unfetch@4.2.0...5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
I'm hoping this addresses #144. The definitions are exported both as
Unfetch
-prefixed names, and within an Unfetch namespace (Unfetch.Response
). They're almost compatible with the standard Response/Headers/RequestInit types, except where Unfetch's Headers implementation uses an Array instead of an Iterable - the types being incompatible there is actually accurate, it's not currently possible to doresponse.headers.entries().next()
in unfetch.